After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706479 - Follow HeaderBar layout guidelines
Follow HeaderBar layout guidelines
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Main Toolbar
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-21 11:06 UTC by Allan Day
Modified: 2013-08-29 14:51 UTC
See Also:
GNOME target: ---
GNOME version: 3.9/3.10

Attachments
modified screenshot (20.83 KB, image/png)
2013-08-21 11:06 UTC, Allan Day 		  Details
toolbar: Remove margin unnecessary (758 bytes, patch)
2013-08-29 12:04 UTC, Yosef Or Boczko 		committed Details | Review
toolbar: Fix the spacing between the buttons (1.87 KB, patch)
2013-08-29 12:04 UTC, Yosef Or Boczko 		committed Details | Review
toolbar: Add style "titlebutton" for the close button (906 bytes, patch)
2013-08-29 12:07 UTC, Yosef Or Boczko 		committed Details | Review

Description Allan Day 2013-08-21 11:06:10 UTC 
Created attachment 252530 [details]
modified screenshot

We need to make sure that HeaderBars look consistent. Guidelines are here:

https://wiki.gnome.org/Design/Whiteboards/HeadeBarGuidelines

Attached image shows current state on top and desired layout below.
Comment 1 Felix Möller 2013-08-27 19:10:31 UTC 
For me the link is broken. I guess https://wiki.gnome.org/Design/Whiteboards/HeaderBars was intended to be linked.
Comment 2 Yosef Or Boczko 2013-08-29 12:04:45 UTC 
Created attachment 253491 [details] [review]
toolbar: Remove margin unnecessary
Comment 3 Yosef Or Boczko 2013-08-29 12:04:57 UTC 
Created attachment 253492 [details] [review]
toolbar: Fix the spacing between the buttons
Comment 4 Yosef Or Boczko 2013-08-29 12:07:29 UTC 
Created attachment 253493 [details] [review]
toolbar: Add style "titlebutton" for the close button

This also relate to the top bar...
Comment 5 Allan Day 2013-08-29 13:38:14 UTC 
The patches look good to me.
Comment 6 Yosef Or Boczko 2013-08-29 14:50:41 UTC 
Review of attachment 253491 [details] [review]:

pushed as 6ac43ab0516fa54406e1833244b54738efc1bc73 - toolbar: Remove margin unnecessary
Comment 7 Yosef Or Boczko 2013-08-29 14:51:05 UTC 
Review of attachment 253492 [details] [review]:

pushed as 3eca97997cb1973f6c7a073cec89a261ec1c59a3  - toolbar: Fix the spacing between the buttons
Comment 8 Yosef Or Boczko 2013-08-29 14:51:26 UTC 
Review of attachment 253493 [details] [review]:

pushed as 40490b472a45b72ebe8cccd3c57e19047e7218f3 - toolbar: Add style "titlebutton" for the close button