After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706252 - ShellAppSystem: handle desktop files with capital letters
ShellAppSystem: handle desktop files with capital letters
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-18 16:30 UTC by Giovanni Campagna
Modified: 2013-08-18 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
ShellAppSystem: handle desktop files with capital letters (1.39 KB, patch)
2013-08-18 16:30 UTC, Giovanni Campagna
committed Details | Review
ShellWindowTracker: support looking apps from GApplication IDs (1.79 KB, patch)
2013-08-18 16:44 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-08-18 16:30:35 UTC
gnome-weather will soon be org.gnome.Weather.Application (hopefully
before 3.9.90), as a preview of the new application deployment
model we talked about at GUADEC, and the wm_class matching is
broken for it without this patch.
Comment 1 Giovanni Campagna 2013-08-18 16:30:37 UTC
Created attachment 252135 [details] [review]
ShellAppSystem: handle desktop files with capital letters

This is needed to handle applications that are converted to
reverse dns notation, if their application ID includes capital
letters (as it is often the case for DBus names)
Comment 2 Giovanni Campagna 2013-08-18 16:44:42 UTC
Created attachment 252136 [details] [review]
ShellWindowTracker: support looking apps from GApplication IDs

In the new application model, there is one ID shared by GApplication,
DBus and .desktop files, so we can use that for the association,
instead of fiddling with badly cased wm classes.

This is the other way to takle the problem. The biggest issue
is that it relies on a GTK specific window property, so it wouldn't
work with applications in the new model written in Qt, for example.
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-08-18 18:30:42 UTC
Review of attachment 252135 [details] [review]:

OK.
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-08-18 18:31:09 UTC
Review of attachment 252136 [details] [review]:

OK.
Comment 5 Giovanni Campagna 2013-08-18 20:08:35 UTC
Attachment 252135 [details] pushed as 2acd23b - ShellAppSystem: handle desktop files with capital letters
Attachment 252136 [details] pushed as 4a3f020 - ShellWindowTracker: support looking apps from GApplication IDs