Created attachment 252050 [details] [review]
Add a confirmation dialog for display changes

Unfortunately, display configuration can and does fail, due
to unspecified HW constraints, drivers bugs, unsupported exotic
configurations or just bad luck.
So when the user makes a change in the control center, show
a dialog asking him if it looks OK, and revert back after 20 seconds
otherwise.

Created attachment 252051 [details]
Screenshot

This is how it looks like - it's a simple toolkit conversion of the Gtk dialog from gnome-settings-daemon.

The left button is truncated, I know.
We can either make the dialog larger (now it's sized like all other modal dialogs), or use a shorter label, eg. "Restore previous"

Do note translations will exist, with different label sizes. Could the dialog be sized according to the label sizes, instead of a manual adjustment targeting English?

Created attachment 252201 [details] [review]
Add a confirmation dialog for display changes

Unfortunately, display configuration can and does fail, due
to unspecified HW constraints, drivers bugs, unsupported exotic
configurations or just bad luck.
So when the user makes a change in the control center, show
a dialog asking him if it looks OK, and revert back after 20 seconds
otherwise.

For the sake of discussion, this is the version that enlarges
to accomodate for longer buttons.

Created attachment 252202 [details] [review]
Add a confirmation dialog for display changes

Unfortunately, display configuration can and does fail, due
to unspecified HW constraints, drivers bugs, unsupported exotic
configurations or just bad luck.
So when the user makes a change in the control center, show
a dialog asking him if it looks OK, and revert back after 20 seconds
otherwise.

And this is the version that uses labels like Windows 7
(http://h10025.www1.hp.com/ewfrf-JAVA/Doc/images/839/c01891593.gif)

In general I like the Windows wording: it is less verbose, and avoids technical terms like "configuration". To keep it GNOMEy, we should have the negative "Undo" action first though. So something like:

Do you want to keep these display settings?

Settings changes will revert in %s seconds

[ Revert Settings ] [ Keep Changes ]

Created attachment 252311 [details] [review]
Add a confirmation dialog for display changes

Unfortunately, display configuration can and does fail, due
to unspecified HW constraints, drivers bugs, unsupported exotic
configurations or just bad luck.
So when the user makes a change in the control center, show
a dialog asking him if it looks OK, and revert back after 20 seconds
otherwise.

Created attachment 252312 [details]
New screenshot

Review of attachment 252311 [details] [review]:

Looks good, just some minor stuff (see below).

::: js/ui/windowManager.js
@@ +56,3 @@
+                         y_align: St.Align.START });
+
+        this._countDown = 20;

Use a constant?

@@ +67,3 @@
+                         y_align: St.Align.START });
+
+        this._cancelButton = this.addButton({ label: _("Revert Settings"),

Add a translator comment that warns about the length.

@@ +71,3 @@
+                                              key: Clutter.Escape },
+                                            { expand: true, x_fill: false, x_align: St.Align.START });
+        this._okButton = this.addButton({ label:  _("Keep Changes"),

Add a translator comment that warns about the length.

@@ +76,3 @@
+                                        { expand: false, x_fill: false, x_align: St.Align.END });
+
+        this._timeoutId = Mainloop.timeout_add(1000, Lang.bind(this, this._tick));

Use a constant?

@@ +1146,3 @@
+
+    _confirmDisplayChange: function() {
+        (new DisplayChangeDialog(this._shellwm)).open();

Use let ... = new .. (); etc looks easier to read then this.

(In reply to comment #9)
> Add a translator comment that warns about the length.

Is it really impossible to adjust to the length of the string?

Created attachment 252344 [details] [review]
Add a confirmation dialog for display changes

Unfortunately, display configuration can and does fail, due
to unspecified HW constraints, drivers bugs, unsupported exotic
configurations or just bad luck.
So when the user makes a change in the control center, show
a dialog asking him if it looks OK, and revert back after 20 seconds
otherwise.

(In reply to comment #10)
> (In reply to comment #9)
> > Add a translator comment that warns about the length.
> 
> Is it really impossible to adjust to the length of the string?

No, see comment 4 ... but the designers want a fixed width for those dialogs.

Review of attachment 252344 [details] [review]:

LG.

Attachment 252344 [details] pushed as 02224bb - Add a confirmation dialog for display changes