After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706057 - core: Remove old "archive" mode
core: Remove old "archive" mode
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-15 10:44 UTC by Colin Walters
Modified: 2013-08-17 02:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: Remove old "archive" mode (15.54 KB, patch)
2013-08-15 10:44 UTC, Colin Walters
committed Details | Review

Description Colin Walters 2013-08-15 10:44:19 UTC
We'll always have "bare" mode for keeping files-as-hardlinks as root.
But "archive" was my second attempt at a format for non-root file
storage, used by the gnome-ostree buildsystem which runs as non-root.

It was really handy to have a "tar" like mode where I can create
tarballs as a user, that contain files owned by root for example.

The "archive" mode stored content files as two pieces in the
filesystem; ".file" contained metadata, and ".filecontent" was the
actual content, uncompressed.  The nice thing about this was that to
check out a tree as non-root, you could just hardlink into the repo.

However, archive was fairly bad for serving via HTTP; it required
*two* HTTP requests per content object, greatly magnifing the already
inefficient fetch process.  So "archive-z2" was introduced.

To allow gnome-ostree to still check out trees as a user, the
"uncompressed-object-cache" was introduced, and that's how things have
been working for a while.

So we should just be able to kill this code.  Specifically note just
how much better the stage_object() function became.
Comment 1 Colin Walters 2013-08-15 10:44:21 UTC
Created attachment 251715 [details] [review]
core: Remove old "archive" mode
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-08-17 02:54:58 UTC
Review of attachment 251715 [details] [review]:

Looks OK.
Comment 3 Colin Walters 2013-08-17 02:57:54 UTC
Attachment 251715 [details] pushed as 1ec7c30 - core: Remove old "archive" mode