After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705919 - gnome-rr: implement gnome_rr_output_get_size_inches
gnome-rr: implement gnome_rr_output_get_size_inches
Status: RESOLVED FIXED
Product: gnome-desktop
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Desktop Maintainers
Desktop Maintainers
Depends on: 706322
Blocks:
 
 
Reported: 2013-08-13 15:50 UTC by Thomas Wood
Modified: 2013-08-19 21:21 UTC
See Also:
GNOME target: 3.10
GNOME version: ---


Attachments
gnome-rr: implement gnome_rr_output_get_size_inches (1.84 KB, patch)
2013-08-13 15:50 UTC, Thomas Wood
accepted-commit_now Details | Review
GnomeRR: read the physical output size for mutter (3.16 KB, patch)
2013-08-19 15:56 UTC, Giovanni Campagna
committed Details | Review

Description Thomas Wood 2013-08-13 15:50:27 UTC
Implement the gnome_rr_output_get_size_inches function.
Comment 1 Thomas Wood 2013-08-13 15:50:29 UTC
Created attachment 251513 [details] [review]
gnome-rr: implement gnome_rr_output_get_size_inches
Comment 2 Matthias Clasen 2013-08-17 04:44:12 UTC
Review of attachment 251513 [details] [review]:

Looks reasonable

::: libgnome-desktop/gnome-rr.h
@@ -151,3 @@
 const char *    gnome_rr_output_get_display_name   (GnomeRROutput         *output);
 gboolean        gnome_rr_output_is_connected       (GnomeRROutput         *output);
-int             gnome_rr_output_get_size_inches    (GnomeRROutput         *output);

huh, this was in the header but not implemented ?
Comment 3 Giovanni Campagna 2013-08-19 15:56:37 UTC
Created attachment 252253 [details] [review]
GnomeRR: read the physical output size for mutter

And expose it in the API, so that the control center can use it
to show the diagonal and aspect ratio.

This is rebased on master. It does not implement get_size_inches()
as requested, because the code to do that is gone. It could be
resurrected, but I think it makes more sense in gnome-control-center
Comment 4 Matthias Clasen 2013-08-19 17:29:16 UTC
Review of attachment 252253 [details] [review]:

looks good to me
Comment 5 Matthias Clasen 2013-08-19 21:21:36 UTC
Attachment 252253 [details] pushed as 375293f - GnomeRR: read the physical output size for mutter