After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705886 - Make headerbar as tittlebar and add close button
Make headerbar as tittlebar and add close button
Status: RESOLVED FIXED
Product: gnome-system-log
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-system-log-maint
gnome-system-log-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-13 09:22 UTC by Yosef Or Boczko
Modified: 2013-08-13 10:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: use G_DEFINE_TYPE_WITH_PRIVATE and use a template to define the UI (40.95 KB, patch)
2013-08-13 09:23 UTC, Yosef Or Boczko 		committed Details | Review
window: make headerbar as titlebar and add close button (12.19 KB, patch)
2013-08-13 09:43 UTC, Yosef Or Boczko 		reviewed Details | Review
Bump GTK requirement (809 bytes, patch)
2013-08-13 10:37 UTC, Yosef Or Boczko 		committed Details | Review
window: make headerbar as titlebar and add close button (12.15 KB, patch)
2013-08-13 10:45 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2013-08-13 09:22:18 UTC 
See patches (them after commit the patches in bug #705881).
Comment 1 Yosef Or Boczko 2013-08-13 09:23:52 UTC 
Created attachment 251449 [details] [review]
window: use G_DEFINE_TYPE_WITH_PRIVATE and use a template to define the UI
Comment 2 Yosef Or Boczko 2013-08-13 09:43:07 UTC 
Created attachment 251452 [details] [review]
window: make headerbar as titlebar and add close button
Comment 3 Cosimo Cecchi 2013-08-13 10:31:36 UTC 
Review of attachment 251449 [details] [review]:

Nice!
Comment 4 Cosimo Cecchi 2013-08-13 10:33:34 UTC 
Review of attachment 251452 [details] [review]:

Looks good to commit, with the following comment fixed.

::: src/logview-window.c
@@ -1245,3 @@
 
-  gtk_window_set_title (GTK_WINDOW (window), _("System Log"));
-  gtk_window_set_icon_name (GTK_WINDOW (window), "logview");

I'd keep these two - they might still be used or displayed when the application runs in a different environment.
Comment 5 Yosef Or Boczko 2013-08-13 10:35:31 UTC 
(In reply to comment #4)
> Review of attachment 251452 [details] [review]:
> 
> Looks good to commit, with the following comment fixed.
> 
> ::: src/logview-window.c
> @@ -1245,3 @@
> 
> -  gtk_window_set_title (GTK_WINDOW (window), _("System Log"));
OK.
> -  gtk_window_set_icon_name (GTK_WINDOW (window), "logview");
> 
Is defined in the .ui file (<property name="icon_name">logview</property>)
> I'd keep these two - they might still be used or displayed when the application
> runs in a different environment.
Comment 6 Yosef Or Boczko 2013-08-13 10:37:26 UTC 
Created attachment 251453 [details] [review]
Bump GTK requirement
Comment 7 Yosef Or Boczko 2013-08-13 10:45:49 UTC 
Created attachment 251454 [details] [review]
window: make headerbar as titlebar and add close button
Comment 8 Cosimo Cecchi 2013-08-13 10:49:01 UTC 
Review of attachment 251453 [details] [review]:

Yes
Comment 9 Cosimo Cecchi 2013-08-13 10:49:44 UTC 
Review of attachment 251454 [details] [review]:

Thanks, missed the icon name in the ui file - looks good now.
Comment 10 Yosef Or Boczko 2013-08-13 10:52:07 UTC 
Review of attachment 251449 [details] [review]:

pushed as f7220c6ab37b2d394f4d055c021838c765285a35 - window: use G_DEFINE_TYPE_WITH_PRIVATE and use a template to define the UI
Comment 11 Yosef Or Boczko 2013-08-13 10:52:38 UTC 
Review of attachment 251454 [details] [review]:

pushed as f7220c6ab37b2d394f4d055c021838c765285a35 - window: make headerbar as titlebar and add close button
Comment 12 Yosef Or Boczko 2013-08-13 10:53:02 UTC 
Review of attachment 251453 [details] [review]:

pushed as 70708b968f2d11535eff20a503499b05cca5cd2a - Bump GTK requirement