After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705869 - gtk-doc.make:77: warning: GTK_DOC_V_SETUP_$(V: non-POSIX recursive variable expansion
gtk-doc.make:77: warning: GTK_DOC_V_SETUP_$(V: non-POSIX recursive variable e...
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.19
Other Linux
: Normal normal
: ---
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-12 19:44 UTC by Simon Josefsson
Modified: 2017-07-20 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch to gtk-doc.make to fix bug 705869 (3.29 KB, patch)
2017-07-17 08:13 UTC, Simon Josefsson
none Details | Review
make: Use portable automake constructs to avoid automake warnings. (3.32 KB, patch)
2017-07-19 19:05 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Simon Josefsson 2013-08-12 19:44:34 UTC
Ever since commit 57fecd (which got included in 1.19) I get warnings during autoreconf of a project that uses the new gtk-doc.make file:

gtk-doc.make:77: warning: GTK_DOC_V_SETUP_$(V: non-POSIX recursive variable expansion

It seems gtk-doc.make is trying to use make constructs directly, but gtk-doc.make is included in Makefile.am's which are processed by automake, so the statements must be valid automake statements.  I haven't analysed this further though, and I'm not sure what the proper fix would be.  I wanted to report it when I noticed it, using the gtk-doc.make file from 1.18 works well for me.

I'm using automake 1.14.

It seems others have noticed this problem before, and worked around it, see discussion: http://patchwork.freedesktop.org/patch/13890/

Thanks,
/Simon
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2013-08-17 19:40:10 UTC
I only have "automake (GNU automake) 1.11.3". More info:
http://www.ostools.net/uploads/apidocs/automake/Automake-silent_002drules-Option.html

See that projects need to apply the patch you suggest, I don't see how gtk-doc could instruct automake to use Wno-portability.
Comment 2 Simon Josefsson 2017-07-17 08:13:36 UTC
Created attachment 355739 [details] [review]
patch to gtk-doc.make to fix bug 705869
Comment 3 Simon Josefsson 2017-07-17 08:14:07 UTC
Using AM_INIT_AUTOMAKE([-Wno-portability]) is not a solution to this problem, it is a workaround.  The problem is in gtk-doc.make, it shouldn't use constructs in an automake file that isn't acceptable to automake.  The solution is at the end of the link you posted -- I prepared a patch for your review.
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2017-07-19 19:01:51 UTC
While this fixes the warning, the build is not silent anymore ...
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2017-07-19 19:04:17 UTC
Nevermind, you've forgot some @ signs.
-GTK_DOC_V_SCAN=$(GTK_DOC_V_SCAN_@AM_V)
+GTK_DOC_V_SCAN=$(GTK_DOC_V_SCAN_@AM_V@)

I'll fix it up. Thanks for the patch.
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2017-07-19 19:05:55 UTC
The following fix has been pushed:
0792d91 make: Use portable automake constructs to avoid automake warnings.
Comment 7 Stefan Sauer (gstreamer, gtkdoc dev) 2017-07-19 19:05:59 UTC
Created attachment 355979 [details] [review]
make: Use portable automake constructs to avoid automake warnings.

This avoids the following -Wportability warning from automake:
warning: GTK_DOC_V_SETUP_$(V: non-POSIX recursive variable expansion

https://bugzilla.gnome.org/show_bug.cgi?id=705869

Signed-off-by: Simon Josefsson <simon@josefsson.org>
Comment 8 Simon Josefsson 2017-07-20 10:09:43 UTC
Thank you!