After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705864 - Make systemd unit dir configurable
Make systemd unit dir configurable
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on: 706022
Blocks:
 
 
Reported: 2013-08-12 17:48 UTC by Sjoerd Simons
Modified: 2013-08-15 22:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (3.05 KB, patch)
2013-08-12 17:48 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2013-08-12 17:48:10 UTC 
Created attachment 251399 [details] [review]
proposed patch

ostree currently hardcodes the system system unit path (depending on the prefix), which is unhelpful if the ostree prefix doesn't match tye systemd system prefix.
Comment 1 Colin Walters 2013-08-13 07:53:28 UTC 
Review of attachment 251399 [details] [review]:

This one looks fine, but if pushed would break gnome-ostree since I'm not at the moment doing "systemctl preset" in buildroot processing.  So give me a bit of time to fix that (which I need to do anyways).

But you can split up the systemd unit prefix fix and push that independently of the [Install] change.

::: configure.ac
@@ +124,3 @@
 AM_CONDITIONAL(BUILDOPT_DRACUT, test x$with_dracut = xyes)
 
+if test "x$with_dracut" = "xyes" ; then

Should be AS_IF().  See https://bugzilla.gnome.org/show_bug.cgi?id=681413
Comment 2 Colin Walters 2013-08-14 20:19:35 UTC 
I filed https://bugzilla.gnome.org/show_bug.cgi?id=706022 for the preset issue.
Comment 3 Colin Walters 2013-08-15 22:30:03 UTC 
I did the AS_IF() fix and pushed, now that gnome-ostree handles systemd [Install] sections.

https://git.gnome.org/browse/ostree/commit/?id=a00eb681a01476534d59e3de715ad9e864be8028