After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705859 - wayland: refactor window destruction and focus
wayland: refactor window destruction and focus
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-12 16:13 UTC by Giovanni Campagna
Modified: 2013-08-13 07:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
wayland: refactor window destruction and focus (16.24 KB, patch)
2013-08-12 16:13 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2013-08-12 16:13:27 UTC
The previous code was leaving focus fields dirty in MetaWaylandPointer
and MetaWaylandKeyboard at time (which could crash the X server
because of invalid object IDs)
The new code is more tighly integrated in the normal X11 code
for handling keyboard focus (meaning that the core idea of input
focus is also correct now), so that meta_window_unmanage() can
do the right thing. As a side benefit, clicking on wayland clients
now unfocus X11 clients.
For the mouse focus, we need to clear the surface pointer when
the metawindowactor is destroyed (even if the actual actor is
kept alive for effects), so that a repick finds a different pointer
focus.
Comment 1 Giovanni Campagna 2013-08-12 16:13:29 UTC
Created attachment 251384 [details] [review]
wayland: refactor window destruction and focus
Comment 2 Giovanni Campagna 2013-08-13 07:44:23 UTC
Attachment 251384 [details] pushed as 9a5f243 - wayland: refactor window destruction and focus
Reviewed by Robert Bragg in IRC.