After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705850 - make distcheck fails on current git
make distcheck fails on current git
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-12 14:34 UTC by Sjoerd Simons
Modified: 2013-08-17 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.49 KB, patch)
2013-08-12 14:34 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2013-08-12 14:34:07 UTC 
Created attachment 251381 [details] [review]
proposed patch

Make distcheck failed for me for various different reasons
  * ostree.h wasn't found during build (probably a generic issue with out of tree builds)
  * make uninstall was broken (left around libostree)
  * make clean was broken (left gir & typelib behind)


Attached patch fixes these
Comment 1 Colin Walters 2013-08-12 21:31:44 UTC 
Review of attachment 251381 [details] [review]:

One thing I should note is that ostree's tests are only installed; there is no "make check" that uses uninstalled binaries.  To run them:

jhbuild buildone ostree  # or whatever build tool
gnome-desktop-testing-runner ostree/

Now I know the build works and the tests are passing since gnome-ostree runs them continuously, which is how I think it should be; but if you find it valuable, we can keep distcheck alive.
Comment 2 Colin Walters 2013-08-17 18:57:44 UTC 
Review of attachment 251381 [details] [review]:

Rebased to master, added a fix or two on top, and pushed.  Thanks!