After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705675 - aiffparse: invalid SSND data size
aiffparse: invalid SSND data size
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal critical
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-08 14:09 UTC by Matthieu Bouron
Modified: 2013-08-12 15:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] aiffparse: fix SSND data size (974 bytes, patch)
2013-08-08 14:10 UTC, Matthieu Bouron 		committed Details | Review

Description Matthieu Bouron 2013-08-08 14:09:11 UTC 
SSND data size is incorrect, actually 8 bytes (chunk header size) larger than it should be. It also prevents the aiff demuxer from reading tags placed after the SSND chunk (ie: ID3 chunk).

AIFF chunk size does not include the chunk header size (8 bytes), so the SSND data size is equal to the chunk size minus the SSND header size (8 bytes).
Comment 1 Matthieu Bouron 2013-08-08 14:10:21 UTC 
Created attachment 251185 [details] [review]
[PATCH] aiffparse: fix SSND data size
Comment 2 Tim-Philipp Müller 2013-08-12 15:16:49 UTC 
Pushed, thanks

 commit 0d4c2f42e9ba8810f6fc5e83c15c1980558239d0
 Author: Matthieu Bouron <matthieu.bouron@collabora.com>
 Date:   Wed Aug 7 10:14:20 2013 +0100

    aiffparse: fix SSND data size
    
    AIFF chunk size does not include the chunk header size (8 bytes), so the
    SSND data size is equal to the chunk size minus the SSND header size (8
    bytes).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705675