After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705601 - headerbar: some improvements
headerbar: some improvements
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-08-07 08:25 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2013-08-07 14:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
close button (1.19 KB, patch)
2013-08-07 08:26 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review
separator improvement (1004 bytes, patch)
2013-08-07 08:26 UTC, Ignacio Casal Quinteiro (nacho) 		rejected Details | Review
before (237.97 KB, image/png)
2013-08-07 08:35 UTC, Ignacio Casal Quinteiro (nacho) 		  Details
after (206.75 KB, image/png)
2013-08-07 08:37 UTC, Ignacio Casal Quinteiro (nacho) 		  Details

Description Ignacio Casal Quinteiro (nacho) 2013-08-07 08:25:46 UTC 
patches coming.
Comment 1 Ignacio Casal Quinteiro (nacho) 2013-08-07 08:26:21 UTC 
Created attachment 251033 [details] [review]
close button

Make it look more like the headerbar buttons
Comment 2 Ignacio Casal Quinteiro (nacho) 2013-08-07 08:26:46 UTC 
Created attachment 251034 [details] [review]
separator improvement

Make the separator look like in the mockups
Comment 3 Ignacio Casal Quinteiro (nacho) 2013-08-07 08:35:59 UTC 
Created attachment 251035 [details]
before

before changes
Comment 4 Ignacio Casal Quinteiro (nacho) 2013-08-07 08:37:08 UTC 
Created attachment 251036 [details]
after

after changes
Comment 5 Jakub Steiner 2013-08-07 09:38:59 UTC 
Review of attachment 251033 [details] [review]:

Can't really judge the code itself, but I like the result of treating the icon in the button the same, thus having a sharp/pixel precise 1:1
Comment 6 Jakub Steiner 2013-08-07 09:42:08 UTC 
Review of attachment 251034 [details] [review]:

While visually this is what I initially intended and most of the mockups have a full headerbar height separator, with a button prelight on :hover making it a proper button, it's actually nicer to have the separator take the same height as the buttons.
Comment 7 Matthias Clasen 2013-08-07 14:47:28 UTC 
Review of attachment 251033 [details] [review]:

I haven't looked at the visuals, but the code looks fine.
Comment 8 Ignacio Casal Quinteiro (nacho) 2013-08-07 14:49:50 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 9 Ignacio Casal Quinteiro (nacho) 2013-08-07 14:50:18 UTC 
Comment on attachment 251033 [details] [review]
close button

https://git.gnome.org/browse/gtk+/commit/?id=fb2bc06f50820a101824a5be7def0fdf0fce7ead
Comment 10 Matthias Clasen 2013-08-07 14:57:57 UTC 
Review of attachment 251034 [details] [review]:

I think we decided to go without this for now