After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705550 - rtpvp8depay: mark key frames and delta frames properly
rtpvp8depay: mark key frames and delta frames properly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other All
: Normal normal
: 1.0.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-06 09:45 UTC by Morgan Lindqvist
Modified: 2013-08-07 10:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Morgan Lindqvist 2013-08-06 09:45:42 UTC 
The VP8 RTP payload depack pluging does not set the GST_BUFFER_FLAG_DELTA_UNIT flag to true or false depending on if the decoded picture is a full intra picture /keyframe or not.

This is done in for instance gstrtph264depay.c using the following code
-----------------
    if (out_keyframe)
      GST_BUFFER_FLAG_UNSET (outbuf, GST_BUFFER_FLAG_DELTA_UNIT);
    else
      GST_BUFFER_FLAG_SET (outbuf, GST_BUFFER_FLAG_DELTA_UNIT);
------------------

In the specification, http://tools.ietf.org/html/rfc6386#section-19.1, it is described how to detect if this picture is a keyframe or not.
Comment 1 Tim-Philipp Müller 2013-08-07 10:22:52 UTC 
Thanks for the bug report.

This should fix it:

 commit 957c8e3e61b61b9e08f1fe493a4dfb5cb49d3293
 Author: Tim-Philipp Müller <tim@centricular.net>
 Date:   Wed Aug 7 11:14:38 2013 +0100

    rtpvp8depay: mark key frames and delta frames properly
    
    https://bugzilla.gnome.org/show_bug.cgi?id=705550