After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705520 - Get rid of the WM's titlebar
Get rid of the WM's titlebar
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-05 14:45 UTC by Debarshi Ray
Modified: 2013-08-13 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
all: Get rid of the WM's titlebar (4.48 KB, patch)
2013-08-05 14:58 UTC, Debarshi Ray 		needs-work Details | Review
all: Get rid of the WM's titlebar (4.00 KB, patch)
2013-08-06 09:27 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-08-05 14:45:40 UTC 
Some of the core applications (eg., gnome-clocks, gnome-weather) are beginning to lose the WM's titlebar. I think we should do the same.
Comment 1 Debarshi Ray 2013-08-05 14:58:02 UTC 
Created attachment 250887 [details] [review]
all: Get rid of the WM's titlebar
Comment 2 Cosimo Cecchi 2013-08-06 08:31:47 UTC 
Review of attachment 250887 [details] [review]:

::: src/embed.js
@@ +442,3 @@
         // pack the toolbar
         this._toolbar = new Preview.PreviewToolbar(this._preview);
+        let toplevel = this.widget.get_toplevel();

I'd rather you got this from the GtkApplication toplevel list instead (also above and below).

::: src/mainToolbar.js
@@ +74,3 @@
     },
 
+    addCloseButton: function() {

Since bug 702971 has been committed to GTK, I think we should use that feature of GtkHeaderBar directly instead.
Comment 3 Debarshi Ray 2013-08-06 09:27:48 UTC 
Created attachment 250946 [details] [review]
all: Get rid of the WM's titlebar
Comment 4 Debarshi Ray 2013-08-06 09:29:56 UTC 
(In reply to comment #2)
> Review of attachment 250887 [details] [review]:
> 
> ::: src/embed.js
> @@ +442,3 @@
>          // pack the toolbar
>          this._toolbar = new Preview.PreviewToolbar(this._preview);
> +        let toplevel = this.widget.get_toplevel();
> 
> I'd rather you got this from the GtkApplication toplevel list instead (also
> above and below).

Ok. Done.

There is one instance of the following snippet in src/selections.js:
        let toplevel = this.widget.get_toplevel();
        if (!toplevel.is_toplevel())

Do you want to similarly replace it?

> ::: src/mainToolbar.js
> @@ +74,3 @@
>      },
> 
> +    addCloseButton: function() {
> 
> Since bug 702971 has been committed to GTK, I think we should use that feature
> of GtkHeaderBar directly instead.

Done.
Comment 5 Cosimo Cecchi 2013-08-13 00:00:27 UTC 
Review of attachment 250946 [details] [review]:

Looks good now, thanks!