After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705431 - Replace MemoryIcon with GBytesIcon
Replace MemoryIcon with GBytesIcon
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.9.x
Other All
: Normal minor
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-04 08:59 UTC by Philip Withnall
Modified: 2013-08-18 00:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace MemoryIcon with GBytesIcon (5.44 KB, patch)
2013-08-04 09:01 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-08-04 08:59:48 UTC 
The new GBytesIcon in GLib 2.37.6 works exactly the same way as MemoryIcon, so we can drop the code for the latter.

This means bumping the GLib dependency from 2.31.10 to 2.37.6.

Patch coming.
Comment 1 Philip Withnall 2013-08-04 09:01:10 UTC 
Created attachment 250786 [details] [review]
Replace MemoryIcon with GBytesIcon
Comment 2 Erick Perez Castellanos 2013-08-09 12:54:54 UTC 
Review of attachment 250786 [details] [review]:

Good to go
Comment 3 Philip Withnall 2013-08-09 18:48:06 UTC 
Comment on attachment 250786 [details] [review]
Replace MemoryIcon with GBytesIcon

Committed to master, thanks.

commit db219966e99a5c6416f53ff8fa005853c7195643
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sun Aug 4 10:57:25 2013 +0200

    Bug 705431 — Replace MemoryIcon with GBytesIcon
    
    This bumps the GLib dependency to 2.37.6.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=705431

 configure.ac                    |  2 +-
 src/Makefile.am                 |  1 -
 src/contacts-avatar-dialog.vala |  9 +++++++--
 src/memory-icon.vala            | 88 ----------------------------------------------------------------------------------------
 4 files changed, 8 insertions(+), 92 deletions(-)
Comment 4 Erick Perez Castellanos 2013-08-12 17:29:44 UTC 
I've found this on folks as well, so you might apply the same patch in folks. I mean not the same, but the same fix, you know.

(In reply to comment #3)
> (From update of attachment 250786 [details] [review])
> Committed to master, thanks.
> 
> commit db219966e99a5c6416f53ff8fa005853c7195643
> Author: Philip Withnall <philip@tecnocode.co.uk>
> Date:   Sun Aug 4 10:57:25 2013 +0200
> 
>     Bug 705431 — Replace MemoryIcon with GBytesIcon
> 
>     This bumps the GLib dependency to 2.37.6.
> 
>     Closes: https://bugzilla.gnome.org/show_bug.cgi?id=705431
> 
>  configure.ac                    |  2 +-
>  src/Makefile.am                 |  1 -
>  src/contacts-avatar-dialog.vala |  9 +++++++--
>  src/memory-icon.vala            | 88
> ----------------------------------------------------------------------------------------
>  4 files changed, 8 insertions(+), 92 deletions(-)
Comment 5 Philip Withnall 2013-08-18 00:55:01 UTC 
(In reply to comment #4)
> I've found this on folks as well, so you might apply the same patch in folks. I
> mean not the same, but the same fix, you know.

That would be bug #705403. :-)