After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705403 - Use GLib.BytesIcon instead of Edsf.MemoryIcon
Use GLib.BytesIcon instead of Edsf.MemoryIcon
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: e-d-s backend
git master
Other All
: Normal minor
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2013-08-03 13:22 UTC by Philip Withnall
Modified: 2013-09-28 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GLib.BytesIcon instead of Edsf.MemoryIcon (7.69 KB, patch)
2013-08-03 13:26 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2013-08-03 13:22:37 UTC 
GLib ≥ 2.37.6 has a new GBytesIcon which does exactly the same as Edsf.MemoryIcon, but can also be serialised to a GVariant. Because deleting code is fun, let’s replace Edsf.MemoryIcon with it.

This won’t change API because MemoryIcon is internal — we expose it as a GLoadableIcon/GIcon.
Comment 1 Philip Withnall 2013-08-03 13:26:08 UTC 
Created attachment 250769 [details] [review]
Use GLib.BytesIcon instead of Edsf.MemoryIcon
Comment 2 Travis Reitter 2013-09-23 16:07:32 UTC 
Review of attachment 250769 [details] [review]:

Looks fine to me. I couldn't verify it due to the EDS test suite failing spectacularly (and inconsistently), but it seems safe enough.
Comment 3 Philip Withnall 2013-09-28 14:07:52 UTC 
Comment on attachment 250769 [details] [review]
Use GLib.BytesIcon instead of Edsf.MemoryIcon

Tested with the changes from bug #679826 applied (to parallelise the test cases) and no new tests fail.

commit 63217d5cb7bc83b476b84313880a005e23223416
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Aug 3 15:24:32 2013 +0200

    Bug 705403 — Use GLib.BytesIcon instead of Edsf.MemoryIcon
    
    Use GLib.BytesIcon internally instead of Edsf.MemoryIcon, which can
    be deleted. This bumps our GLib requirement to 2.37.6, but doesn’t
    affect API.
    
    Closes: https://bugzilla.gnome.org/show_bug.cgi?id=705403

 NEWS                               |   2 ++
 backends/eds/lib/Makefile.am       |   1 -
 backends/eds/lib/edsf-persona.vala |   3 ++-
 backends/eds/lib/memory-icon.vala  | 135 ---------------------------------------------------------------------------------------------------------------------------------------
 configure.ac                       |   2 +-
 5 files changed, 5 insertions(+), 138 deletions(-)