GNOME Bugzilla – Bug 705270
Rework a bit the interface
Last modified: 2013-08-01 19:30:33 UTC
We have search, hooray! Now let's make it look a bit more gnome-y
Created attachment 250594 [details] [review] Rework a bit the interface Move the searchbar in a more usual position and add a search button (inactive for now). Also, remove some useless margins from the treeviews.
Created attachment 250595 [details] [review] Wire up search button And use for search the accelerator Control+F, stealing it from openfiles action.
Created attachment 250596 [details] [review] Rework a bit the interface Move the searchbar in a more usual position and add a search button (inactive for now). Also, remove some useless margins from the treeviews. ---------- Opss, there'a a gtk_widget_show() which should have been a gtk_widget_hide()
Created attachment 250599 [details] [review] Wire up search button And use for search the accelerator Control+F, stealing it from openfiles action. ----- and here I forgot to disable search when changing page.
Attachment 250596 [details] pushed as 4fd60fe - Rework a bit the interface Attachment 250599 [details] pushed as d60e02e - Wire up search button
What do you think, wouldn't a wider searchbar a better fit? I don't know which app to compare to, and I haven't found the new HIG yet, but it's strange for me to have a relatively small textbox in the middle of the searchbar.
(In reply to comment #6) > What do you think, wouldn't a wider searchbar a better fit? I don't know which > app to compare to, and I haven't found the new HIG yet, but it's strange for me > to have a relatively small textbox in the middle of the searchbar. Many apps use a 500px search entry (Documents, gitg, Notes), but for System Monitor is seems a bit too wide. Maybe 300px is enough, don't know. For sure the default is really too small :)
Yes, 300 px seems fine, even with the minimal window size, so I have set that. Your fixes also look fine, marking this as closed. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.