After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705270 - Rework a bit the interface
Rework a bit the interface
Status: RESOLVED FIXED
Product: system-monitor
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: System-monitor maintainers
System-monitor maintainers
Depends on:
Blocks:
 
 
Reported: 2013-08-01 09:14 UTC by Stefano Facchini
Modified: 2013-08-01 19:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Rework a bit the interface (8.91 KB, patch)
2013-08-01 09:14 UTC, Stefano Facchini
none Details | Review
Wire up search button (2.96 KB, patch)
2013-08-01 09:15 UTC, Stefano Facchini
none Details | Review
Rework a bit the interface (8.91 KB, patch)
2013-08-01 09:21 UTC, Stefano Facchini
committed Details | Review
Wire up search button (3.34 KB, patch)
2013-08-01 09:35 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2013-08-01 09:14:57 UTC
We have search, hooray! Now let's make it look a bit more gnome-y
Comment 1 Stefano Facchini 2013-08-01 09:14:59 UTC
Created attachment 250594 [details] [review]
Rework a bit the interface

Move the searchbar in a more usual position and add a search
button (inactive for now).

Also, remove some useless margins from the treeviews.
Comment 2 Stefano Facchini 2013-08-01 09:15:30 UTC
Created attachment 250595 [details] [review]
Wire up search button

And use for search the accelerator Control+F, stealing it from
openfiles action.
Comment 3 Stefano Facchini 2013-08-01 09:21:11 UTC
Created attachment 250596 [details] [review]
Rework a bit the interface

Move the searchbar in a more usual position and add a search
button (inactive for now).

Also, remove some useless margins from the treeviews.

----------
Opss, there'a a gtk_widget_show() which should have been a gtk_widget_hide()
Comment 4 Stefano Facchini 2013-08-01 09:35:21 UTC
Created attachment 250599 [details] [review]
Wire up search button

And use for search the accelerator Control+F, stealing it from
openfiles action.

-----
and here I forgot to disable search when changing page.
Comment 5 Robert Roth 2013-08-01 15:09:32 UTC
Attachment 250596 [details] pushed as 4fd60fe - Rework a bit the interface
Attachment 250599 [details] pushed as d60e02e - Wire up search button
Comment 6 Robert Roth 2013-08-01 16:25:33 UTC
What do you think, wouldn't a wider searchbar a better fit? I don't know which app to compare to, and I haven't found the new HIG yet, but it's strange for me to have a relatively small textbox in the middle of the searchbar.
Comment 7 Stefano Facchini 2013-08-01 17:30:38 UTC
(In reply to comment #6)
> What do you think, wouldn't a wider searchbar a better fit? I don't know which
> app to compare to, and I haven't found the new HIG yet, but it's strange for me
> to have a relatively small textbox in the middle of the searchbar.

Many apps use a 500px search entry (Documents, gitg, Notes), but for System Monitor is seems a bit too wide. Maybe 300px is enough, don't know. For sure the default is really too small :)
Comment 8 Robert Roth 2013-08-01 19:30:33 UTC
Yes, 300 px seems fine, even with the minimal window size, so I have set that. Your fixes also look fine, marking this as closed.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.