GNOME Bugzilla – Bug 705109
audiodecoder/videodecoder: Needs to flush taglist on reception of stream-start
Last modified: 2013-08-12 11:04:16 UTC
Created attachment 250416 [details] [review] audiodecoder: Clear taglist on reception of a STREAM_START event The audiobasedecoder class will merge the taglists from the GST_EVENT_TAGS into a single taglist. However, the tags should be flushed/emptied on reception of a GST_EVENT_STREAM_START event, otherwise, the tags will only cumulate in case we change the source mid stream. Please find attached, a patch that will clear the tags on stream-start event.
Comment on attachment 250416 [details] [review] audiodecoder: Clear taglist on reception of a STREAM_START event Please push and do exactly the same for videodecoder.
Created attachment 250508 [details] [review] videodecoder: Clear taglist on reception of a STREAM_START event Thanks for the review, I've done the same thing for videodecoder. I've attached the patch here, I don't have commit access to the gstreamer repositories afaik.
commit ca2a5153739955e99bd166b136384d15ffe41986 Author: Youness Alaoui <youness.alaoui@collabora.co.uk> Date: Thu Jul 25 20:47:02 2013 -0400 audiodecoder: Clear taglist on reception of a STREAM_START event https://bugzilla.gnome.org/show_bug.cgi?id=705109 commit 17eb692c6a57e82a8cfc3c6511056a1a68ea3774 Author: Youness Alaoui <youness.alaoui@collabora.co.uk> Date: Tue Jul 30 17:37:43 2013 -0400 videodecoder: Clear taglist on reception of a STREAM_START event https://bugzilla.gnome.org/show_bug.cgi?id=705109