After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705054 - Embed manifest into gtk-update-icon-cache.exe
Embed manifest into gtk-update-icon-cache.exe
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
unspecified
Other Windows
: Normal minor
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-07-29 04:01 UTC by LRN
Modified: 2014-08-03 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Embed manifest into gtk-update-icon-cache.exe (2.50 KB, patch)
2013-07-29 04:03 UTC, LRN 		none Details | Review
Embed manifest into gtk-update-icon-cache.exe (gtk+-3.0 version) (1.55 KB, patch)
2014-01-23 05:56 UTC, LRN 		none Details | Review
Embed manifest into gtk-update-icon-cache.exe (2.15 KB, patch)
2014-07-31 10:07 UTC, LRN 		none Details | Review
Embed manifest into gtk-update-icon-cache.exe (2.19 KB, patch)
2014-07-31 15:56 UTC, LRN 		reviewed Details | Review
Embed manifest into gtk-update-icon-cache.exe (2.77 KB, patch)
2014-07-31 16:36 UTC, LRN 		none Details | Review
Embed manifest into gtk-update-icon-cache.exe (2.18 KB, patch)
2014-08-02 10:51 UTC, LRN 		committed Details | Review
Embed manifest into gtk-update-icon-cache.exe (2.77 KB, patch)
2014-08-02 10:52 UTC, LRN 		committed Details | Review

Description LRN 2013-07-29 04:01:31 UTC 
Instead of installing the manifest file alongside gtk-update-icon-cache.exe, it should be simply embedded into the program.
Comment 1 LRN 2013-07-29 04:03:06 UTC 
Created attachment 250344 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

Patch against gtk+-2.0-2.24.20-1, trivial to adapt to 3.x (manifest + rc -> object file; link object file into executable as usual).
Comment 2 LRN 2014-01-23 05:56:16 UTC 
Created attachment 267018 [details] [review]
Embed manifest into gtk-update-icon-cache.exe (gtk+-3.0 version)

This is against 3.11.4
Comment 3 LRN 2014-07-31 10:07:05 UTC 
Created attachment 282130 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

This way it doesn't need to be installed alongside it.
Comment 4 LRN 2014-07-31 15:56:38 UTC 
Created attachment 282186 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

This way it doesn't need to be installed alongside it.

v2: Change 1 and 24 to CREATEPROCESS_MANIFEST_RESOURCE_ID and RT_MANIFEST
Comment 5 LRN 2014-07-31 16:36:03 UTC 
Created attachment 282187 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

Version for gtk-2-24 branch
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-08-02 08:16:08 UTC 
Review of attachment 282186 [details] [review]:

Patch looks good to me. Just the minor nitpick

::: gtk/Makefile.am
@@ +1665,3 @@
 	 echo '</assembly>' ) >$@
 
+

too many empty lines here?
Comment 7 LRN 2014-08-02 10:51:13 UTC 
Created attachment 282325 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

This way it doesn't need to be installed alongside it.

v3: removed empty lines
Comment 8 LRN 2014-08-02 10:52:42 UTC 
Created attachment 282326 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

gtk-2-24 version

v3: remove empty lines
Comment 9 Matthias Clasen 2014-08-03 00:14:35 UTC 
Review of attachment 282325 [details] [review]:

ok
Comment 10 Matthias Clasen 2014-08-03 00:14:55 UTC 
Review of attachment 282326 [details] [review]:

ok
Comment 11 LRN 2014-08-03 06:50:19 UTC 
Comment on attachment 282325 [details] [review]
Embed manifest into gtk-update-icon-cache.exe

Attachment 282325 [details] pushed as 7fd9080 - Embed manifest into gtk-update-icon-cache.exe
Comment 12 LRN 2014-08-03 06:52:52 UTC 
Attachment 282326 [details] pushed as d0c0d65 - Embed manifest into gtk-update-icon-cache.exe