After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704996 - qtdemux: support for H264 fourcc
qtdemux: support for H264 fourcc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.1.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-27 16:16 UTC by Matej Knopp
Modified: 2013-07-29 09:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (3.35 KB, patch)
2013-07-27 16:16 UTC, Matej Knopp 		committed Details | Review
Check for data size (1.80 KB, patch)
2013-07-29 09:22 UTC, Matej Knopp 		committed Details | Review

Description Matej Knopp 2013-07-27 16:16:12 UTC 
Created attachment 250273 [details] [review]
Patch

Sample file has H264 fourcc (instead of avc1) and codec data is in strf atom. The file was created in QuickTime (i think) and play with desktop QuickTime and libav.

https://s3.amazonaws.com/MatejK/Samples/h264fourcc.mov
Comment 1 Sebastian Dröge (slomo) 2013-07-29 07:13:34 UTC 
commit 2dcdfe07f76dc7be5e8f9a3c8020d74d00dc1e3b
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Sat Jul 27 18:10:22 2013 +0200

    qtdemux: Support H264 fourcc
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704996
Comment 2 Tim-Philipp Müller 2013-07-29 08:28:28 UTC 
I presume you make sure everywhere that you're not accessing atoms out of bounds? (i.e. check length before accessing data + X)
Comment 3 Matej Knopp 2013-07-29 08:51:48 UTC 
You mean when parsing the strf atom? It does same checking as the code that parses the avcC atom, i.e. not much :) probably could be improved.
Comment 4 Matej Knopp 2013-07-29 08:54:25 UTC 
Actually, it does seem to do worse. I'll submit a patch.
Comment 5 Matej Knopp 2013-07-29 09:22:52 UTC 
Created attachment 250357 [details] [review]
Check for data size

Sorry, this should have been in the first patch.
Comment 6 Sebastian Dröge (slomo) 2013-07-29 09:53:54 UTC 
Comment on attachment 250357 [details] [review]
Check for data size

commit 47ed79fb1c8dafbd7c721e3b9bfb7723f4be3174
Author: Matej Knopp <matej.knopp@gmail.com>
Date:   Mon Jul 29 11:18:40 2013 +0200

    qtdemux: Check for data size when parsing h264 codec data from strf atom



Sorry for missing that