After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704986 - Improve error message when illegal move occurs
Improve error message when illegal move occurs
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
3.9.x
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-chess-maint
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-27 14:53 UTC by Michael Catanzaro
Modified: 2014-01-07 21:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Report an error when something goes wrong (4.76 KB, patch)
2013-08-19 04:07 UTC, Michael Catanzaro 		committed Details | Review
Differentiate a dead engine from illegal moves (2.35 KB, patch)
2014-01-07 21:32 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2013-07-27 14:53:20 UTC 
Right now, if the GNOME Chess allows an illegal move (fortunately I'm not aware of any remaining such bugs), or if an engine makes an illegal move, you get an "AI hang": the game is effectively over, with no user feedback whatsoever.  Instead, we need to report the error to the user.
Comment 1 Michael Catanzaro 2013-08-19 04:07:21 UTC 
The following fix has been pushed:
9324e7c Report an error when something goes wrong
Comment 2 Michael Catanzaro 2013-08-19 04:07:23 UTC 
Created attachment 252176 [details] [review]
Report an error when something goes wrong

* If an engine attempts to make an illegal move
* If an engine claims we allowed an illegal move

There ought to also be a descriptive error message, but there isn't yet.
But it's way better than appearing to freeze.
Comment 3 Michael Catanzaro 2014-01-07 21:32:23 UTC 
The following fix has been pushed:
4d599e3 Differentiate a dead engine from illegal moves
Comment 4 Michael Catanzaro 2014-01-07 21:32:25 UTC 
Created attachment 265590 [details] [review]
Differentiate a dead engine from illegal moves