After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704926 - audiodecoder: leaks input caps
audiodecoder: leaks input caps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 1.0.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-26 12:31 UTC by Matej Knopp
Modified: 2013-07-26 14:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.49 KB, patch)
2013-07-26 12:31 UTC, Matej Knopp
committed Details | Review

Description Matej Knopp 2013-07-26 12:31:45 UTC
Created attachment 250194 [details] [review]
Patch

in gst_audio_decoder_reset dec->priv->ctx gets memset to 0 before gst_caps_replace
Comment 1 Matej Knopp 2013-07-26 12:33:43 UTC
I've also put gst_audio_info_init after the memset.
Comment 2 Tim-Philipp Müller 2013-07-26 14:49:55 UTC
I'm sure I've fixed this already somewhere, wonder how many copy'n'pastes of that code are around :)

 commit 197376212c6f54b688f048a67723e53c702d97ac
 Author: Matej Knopp <matej.knopp@gmail.com>
 Date:   Fri Jul 26 14:28:41 2013 +0200

    audiodecoder: do not leak input caps
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704926