After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704747 - [PATCH] testsuite/a11y: Don't check minimum increment
[PATCH] testsuite/a11y: Don't check minimum increment
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-07-23 14:42 UTC by Colin Walters
Modified: 2013-07-24 01:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix (8.00 KB, patch)
2013-07-23 14:43 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Colin Walters 2013-07-23 14:42:17 UTC 
This value is highly sensitive to changes in the theme; we
don't want to have to tweak hardcoded integers in this test case
every time we rev gnome-themes-standard.

Future iterations could do more heuristic matching, but this
is enough for now.
Comment 1 Colin Walters 2013-07-23 14:43:24 UTC 
Created attachment 249900 [details] [review]
fix
Comment 2 Matthias Clasen 2013-07-24 01:41:00 UTC 
Review of attachment 249900 [details] [review]:

Makes sense, thanks for looking into this.

::: testsuite/a11y/accessibility-dump.c
@@ +461,2 @@
   g_value_reset (&value);
   g_value_reset (&svalue);

Would be nice to leave a comment here that says something like
"We used to dump the minimum increment here, but the value is too sensitive to theme changes to allow sensible comparison with expected output."
Comment 3 Matthias Clasen 2013-07-24 01:41:19 UTC 
Review of attachment 249900 [details] [review]:

Makes sense, thanks for looking into this.

::: testsuite/a11y/accessibility-dump.c
@@ +461,2 @@
   g_value_reset (&value);
   g_value_reset (&svalue);

Would be nice to leave a comment here that says something like
"We used to dump the minimum increment here, but the value is too sensitive to theme changes to allow sensible comparison with expected output."
Comment 4 Colin Walters 2013-07-24 01:54:56 UTC 
Pushed with comment, thanks!