Created attachment 249657 [details] [review]
shell-app: Fade the app icon on the left in RTL layouts

The point of fading the icon is to make the text displayed over the
icon more legible. In RTL layouts, the text is displayed on the left
of the icon, so fading the right-hand-side of the icon doesn't work
well.

Review of attachment 249657 [details] [review]:

Just a style nit

::: src/shell-app.c
@@ +302,3 @@
           guchar *pixel = &pixels[j * rowstride + i * n_channels];
+          float fade = ((float) i - fade_start) / (fade_end - fade_start);
+          /* fade at the right side for LTR, left side for RTL */

Place this comment above the first if (data->direction)

Attachment 249657 [details] pushed as 1cc5bb5 - shell-app: Fade the app icon on the left in RTL layouts