GNOME Bugzilla – Bug 704431
tests can't find sample files when srcdir != builddir
Last modified: 2015-09-28 13:21:29 UTC
In latest release ubuntu build fails with failed boundaries test, since it can't find the sample utf8 file. I suppose this is a regression from e17b595e3bacfb7333bab6fcd1c62d05e7228936 testboundaries.log: /text/boundaries: sample file: /tmp/buildd/pango1.0-1.35.0/debian/build/shared/tests/boundaries.utf8 line 0 offset 0 char is 000000: Couldn't open sample text file (line is '(null)') prior to the above commit, test data was being loaded from srcdir = /tmp/buildd/pango1.0-1.35.0/./tests
It appears that for G_TEST_DIST to work correctly it is needed to include glib.mk, however I tried to patch the build system similar to what was recently done in gdk-pixbuf, but unfortunately its still not working.
Matthias?
Created attachment 249589 [details] [review] Include glib.mk so tests work when srcdir != builddir
I attached the patch I made, but right now its not actually working.
Downstream bug report with workaround (set G_TEST_SRCDIR) included: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=727174
for G_TEST_DIST to work, the documentation states that G_TEST_SRCDIR and G_TEST_BUILDDIR env vars need to be set - which we do in tests/Makefile.am: TESTS_ENVIRONMENT = \ srcdir=$(srcdir) \ G_TEST_SRCDIR=$(abs_srcdir) \ G_TEST_BUILDDIR=$(abs_builddir) \ PANGO_RC_FILE=./pangorc So, the claim in the upstream bug that 'nothing in the build system sets this' is wrong. Whatever is going wrong here needs some more debugging, I'm afraid.
https://git.gnome.org/browse/pango/commit/?id=07de8494412e6d735c5fa04aa8bdf1632582d098 (included in release since 1.36.3)