After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704357 - regression: videocrop unit test fail after adding GRAY16_BE format
regression: videocrop unit test fail after adding GRAY16_BE format
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.x
Other Linux
: Normal normal
: 1.1.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-16 23:52 UTC by Nicolas Dufresne (ndufresne)
Modified: 2013-07-18 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] videocrop: Fix unit for GRAY16 formats (1.76 KB, patch)
2013-07-17 00:48 UTC, Nicolas Dufresne (ndufresne) 		committed Details | Review

Description Nicolas Dufresne (ndufresne) 2013-07-16 23:52:40 UTC 
There is a regression according to videocrop unit tests. The cause seems the following patch:

commit 837dcfb3638ea3f88f9ff8192f63e1ddc935e1a3
Author: Joshua M. Doe <oss@nvl.army.mil>
Date:   Tue May 14 10:28:10 2013 -0400

    videocrop: Add support for GRAY16_LE/GRAY16_BE
    
    https://bugzilla.gnome.org/show_bug.cgi?id=700331
Comment 1 Nicolas Dufresne (ndufresne) 2013-07-17 00:14:45 UTC 
The value after cropping seems good, though the test seems wrong:
  
   values[i] >> (8 - depth));

Where depth is 16, means we try to shift -8 (a bit number which will guaranty having 0 on any platforms). Also, this value array seems specific to 8bit.
Comment 2 Nicolas Dufresne (ndufresne) 2013-07-17 00:48:11 UTC 
Created attachment 249336 [details] [review]
[PATCH] videocrop: Fix unit for GRAY16 formats

 tests/check/elements/videocrop.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)
Comment 3 Nicolas Dufresne (ndufresne) 2013-07-17 00:48:44 UTC 
Would that patch be ok ?
Comment 4 Sebastian Dröge (slomo) 2013-07-17 08:19:12 UTC 
Comment on attachment 249336 [details] [review]
[PATCH] videocrop: Fix unit for GRAY16 formats

Yes
Comment 5 Nicolas Dufresne (ndufresne) 2013-07-18 14:58:14 UTC 
Comment on attachment 249336 [details] [review]
[PATCH] videocrop: Fix unit for GRAY16 formats

I again forgot to modify the commit log, sorry Tim.

commit 01b20ab901a59db8c148504893db09b976c47c01
Author: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date:   Tue Jul 16 20:41:15 2013 -0400

    videocrop: Fix unit for GRAY16 formats