After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704241 - souphttpsrc: Ignore all HEAD errors
souphttpsrc: Ignore all HEAD errors
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.1.2
Other Linux
: Normal normal
: 1.1.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-15 11:58 UTC by Arnaud Vrac
Modified: 2013-07-25 16:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Always ignore HEAD errors (3.82 KB, patch)
2013-07-15 11:58 UTC, Arnaud Vrac 		none Details | Review
fail log (8.39 KB, text/plain)
2013-07-15 11:59 UTC, Arnaud Vrac 		  Details
Always ignore HEAD errors (3.78 KB, patch)
2013-07-25 14:21 UTC, Arnaud Vrac 		committed Details | Review

Description Arnaud Vrac 2013-07-15 11:58:12 UTC 
Created attachment 249185 [details] [review]
Always ignore HEAD errors

souphttpsrc now does a HEAD request at start which prevents playback with servers that do not support this method (ie a 405 http error is returned). I've attached a sample log.

The solution is to always ignore HEAD errors, the attached patch does this.

Also I'm not sure why the HEAD request is always needed, shouldn't it only be done when requesting if the stream is seekable in READY state ?
Comment 1 Arnaud Vrac 2013-07-15 11:59:01 UTC 
Created attachment 249186 [details]
fail log
Comment 2 Thiago Sousa Santos 2013-07-15 12:26:48 UTC 
This should already be fixed on upstream git.

*** This bug has been marked as a duplicate of bug 704053 ***
Comment 3 Arnaud Vrac 2013-07-15 12:29:04 UTC 
It's not, in upstream git only transport errors are ignored, not server errors (which includes 405 status code).
Comment 4 Sebastian Dröge (slomo) 2013-07-15 12:41:41 UTC 
Wouldn't we want redirections already be handled for the HEAD request too? Otherwise this patch looks good
Comment 5 Tim-Philipp Müller 2013-07-23 09:41:50 UTC 
Arnaud?
Comment 6 Arnaud Vrac 2013-07-25 14:21:53 UTC 
Created attachment 250122 [details] [review]
Always ignore HEAD errors

I've checked, the HEAD request does handle redirection when automatic-redirect is set. I've updated the patch to not print the "Ignoring error %d during HEAD request" on success, but that's it.
Comment 7 Sebastian Dröge (slomo) 2013-07-25 16:01:56 UTC 
commit e67655608cc14836c5ea55206787d680b6526d65
Author: Arnaud Vrac <avrac@freebox.fr>
Date:   Fri Jul 12 20:01:42 2013 +0200

    souphttpsrc: always ignore HEAD errors
    
    https://bugzilla.gnome.org/show_bug.cgi?id=704241