After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704186 - Fix the look of back button and next button in history dialog
Fix the look of back button and next button in history dialog
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: User Accounts
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: Ondrej Holy
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-07-14 10:14 UTC by Yosef Or Boczko
Modified: 2013-07-17 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
user-accounts: Fix the look of back button and next button in history dialog (6.62 KB, patch)
2013-07-14 10:16 UTC, Yosef Or Boczko
none Details | Review
History dialog - before (21.29 KB, image/png)
2013-07-14 10:17 UTC, Yosef Or Boczko
  Details
History dialog - after (21.41 KB, image/png)
2013-07-14 10:17 UTC, Yosef Or Boczko
  Details
user-accounts: set back button and next button in history-dialog as none relief (1.47 KB, patch)
2013-07-14 10:26 UTC, Yosef Or Boczko
none Details | Review
History dialog - after - none relief (26.77 KB, image/png)
2013-07-14 10:27 UTC, Yosef Or Boczko
  Details
History dialog - after - none relief (26.51 KB, image/png)
2013-07-14 10:31 UTC, Yosef Or Boczko
  Details
user-accounts: Fix the look of back button and next button in history dialog (6.36 KB, patch)
2013-07-14 23:10 UTC, Yosef Or Boczko
needs-work Details | Review
user-accounts: set back button and next button in history-dialog as none relief (1.37 KB, patch)
2013-07-14 23:12 UTC, Yosef Or Boczko
rejected Details | Review
user-accounts: fix the look of the arrows in the history dialog (5.29 KB, patch)
2013-07-17 14:06 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2013-07-14 10:14:20 UTC
The mockup (from bug #681772, comment #c30):
https://bug681772.bugzilla-attachments.gnome.org/attachment.cgi?id=230518
Comment 1 Yosef Or Boczko 2013-07-14 10:16:07 UTC
Created attachment 249106 [details] [review]
user-accounts: Fix the look of back button and next button in history dialog
Comment 2 Yosef Or Boczko 2013-07-14 10:17:29 UTC
Created attachment 249107 [details]
History dialog - before
Comment 3 Yosef Or Boczko 2013-07-14 10:17:42 UTC
Created attachment 249108 [details]
History dialog - after
Comment 4 Yosef Or Boczko 2013-07-14 10:26:53 UTC
Created attachment 249109 [details] [review]
user-accounts: set back button and next button in history-dialog as none relief

I think it's more beautiful (should ask the designer for this).
Comment 5 Yosef Or Boczko 2013-07-14 10:27:51 UTC
Created attachment 249110 [details]
History dialog - after - none relief
Comment 6 Yosef Or Boczko 2013-07-14 10:31:20 UTC
Created attachment 249111 [details]
History dialog - after - none relief
Comment 7 Yosef Or Boczko 2013-07-14 23:10:18 UTC
Created attachment 249146 [details] [review]
user-accounts: Fix the look of back button and next button in history dialog

move set a class style to .ui file.
Comment 8 Yosef Or Boczko 2013-07-14 23:12:45 UTC
Created attachment 249147 [details] [review]
user-accounts: set back button and next button in history-dialog as none relief
Comment 9 Allan Day 2013-07-15 14:50:59 UTC
Obviously better. You have my blessing.
Comment 10 Ondrej Holy 2013-07-17 13:10:41 UTC
Review of attachment 249146 [details] [review]:

Thank you for your patches.

::: panels/user-accounts/data/history-dialog.ui
@@ +167,3 @@
+                        <child>
+                          <placeholder/>
+                        </child>

Please remove all these placeholders.

::: panels/user-accounts/um-history-dialog.c
@@ +358,3 @@
 
+        widget = get_widget (um, "next-image");
+        g_object_set (widget, "icon_name", rtl ? "go-next-rtl-symbolic" : "go-next-symbolic", NULL);

Isn't it better to use gtk_image_set_from_icon_name instead g_object_set?

@@ +361,3 @@
+
+        widget = get_widget (um, "previous-image");
+        g_object_set (widget, "icon_name", rtl ? "go-previous-rtl-symbolic" : "go-previous-symbolic", NULL);

Same here...
Comment 11 Ondrej Holy 2013-07-17 13:14:37 UTC
Review of attachment 249147 [details] [review]:

Please use shorter commit message (also in your previous patch):

https://wiki.gnome.org/Git/CommitMessages

It looks good otherwise.
Comment 12 Yosef Or Boczko 2013-07-17 14:06:04 UTC
Created attachment 249405 [details] [review]
user-accounts: fix the look of the arrows in the history dialog

the commit messages is good?
Comment 13 Ondrej Holy 2013-07-17 16:09:53 UTC
Review of attachment 249405 [details] [review]:

It looks good to me.
Comment 14 Ondrej Holy 2013-07-17 16:16:59 UTC
Are the assigned screenshots real? Have you there logs without time? Could you file it as new bug please? 

To the new bug report please assign output of commands:

last

and (where 1000 replace by your uid):

dbus-send --system --print-reply --dest=org.freedesktop.Accounts /org/freedesktop/Accounts/User1000 org.freedesktop.DBus.Properties.Get string:'org.freedesktop.Accounts.User' string:'LoginHistory'
Comment 15 Yosef Or Boczko 2013-07-17 16:31:56 UTC
Review of attachment 249405 [details] [review]:

pushed as 55b212075fd7f1b6801592a5e65e3d8fbf332f01 - user-accounts: fix the look of the arrows in the history dialog
Comment 16 Yosef Or Boczko 2013-07-17 16:42:44 UTC
Review of attachment 249147 [details] [review]:

aday rejected it.