After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703954 - Clean up the code handling --in-builddir and --in-checkoutdir
Clean up the code handling --in-builddir and --in-checkoutdir
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2013-07-10 14:57 UTC by Emanuele Aina
Modified: 2013-07-10 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
run: Deduplicate the code handling --in-builddir and --in-checkoutdir (2.59 KB, patch)
2013-07-10 14:57 UTC, Emanuele Aina 		committed Details | Review
run: Simplify code using a single-item list (1.53 KB, patch)
2013-07-10 14:57 UTC, Emanuele Aina 		committed Details | Review
run: Simplify code using a single-item list (1.53 KB, patch)
2013-07-10 16:00 UTC, Emanuele Aina 		committed Details | Review
run: Deduplicate the code handling --in-builddir and --in-checkoutdir (2.59 KB, patch)
2013-07-10 16:00 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2013-07-10 14:57:19 UTC 
In bug #700731 Colin suggested a change to make the code a bit clearer since
during the years it grew out a bit byzantine. I went a bit further on that and
merged as far as possible the handling of the --in-builddir and
--in-checkoutdir options.
Comment 1 Emanuele Aina 2013-07-10 14:57:22 UTC 
Created attachment 248838 [details] [review]
run: Deduplicate the code handling --in-builddir and --in-checkoutdir
Comment 2 Emanuele Aina 2013-07-10 14:57:28 UTC 
Created attachment 248839 [details] [review]
run: Simplify code using a single-item list
Comment 3 Colin Walters 2013-07-10 14:59:46 UTC 
Review of attachment 248838 [details] [review]:

Nice, this looks good.
Comment 4 Colin Walters 2013-07-10 15:00:11 UTC 
Review of attachment 248839 [details] [review]:

Looks good, thanks!
Comment 5 Emanuele Aina 2013-07-10 16:00:28 UTC 
The following fixes have been pushed:
68e3dcd run: Simplify code using a single-item list
7a71be6 run: Deduplicate the code handling --in-builddir and --in-checkoutdir
Comment 6 Emanuele Aina 2013-07-10 16:00:45 UTC 
Created attachment 248845 [details] [review]
run: Simplify code using a single-item list
Comment 7 Emanuele Aina 2013-07-10 16:00:49 UTC 
Created attachment 248846 [details] [review]
run: Deduplicate the code handling --in-builddir and --in-checkoutdir