After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703837 - board numbering is upside down when black side is in view
board numbering is upside down when black side is in view
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
gnome-chess-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-09 01:29 UTC by Adam Dingle
Modified: 2013-07-20 02:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
2D: fix board numbering when Black is on bottom (2.06 KB, patch)
2013-07-15 03:45 UTC, Michael Catanzaro 		committed Details | Review
Depend on unreleased Vala (699 bytes, patch)
2013-07-15 03:45 UTC, Michael Catanzaro 		committed Details | Review
2D: fix board numbering when Black is on bottom (2.08 KB, patch)
2013-07-15 03:53 UTC, Michael Catanzaro 		none Details | Review
3D: fix board numbering when Black is on bottom (1.83 KB, patch)
2013-07-20 02:24 UTC, Michael Catanzaro 		committed Details | Review

Description Adam Dingle 2013-07-09 01:29:29 UTC 
To see the problem, set Board Orientation to "Black Side" and enable the Board Numbering preference.  The letters and numbers around the edges of the board will appear upside down, unnecessarily.
Comment 1 Michael Catanzaro 2013-07-09 01:41:28 UTC 
I think the text would get bored if it had to be right-side-up all day.
Comment 2 Michael Catanzaro 2013-07-15 03:45:46 UTC 
Created attachment 249154 [details] [review]
2D: fix board numbering when Black is on bottom
Comment 3 Michael Catanzaro 2013-07-15 03:45:48 UTC 
Created attachment 249155 [details] [review]
Depend on unreleased Vala

The Cairo.Matrix.get_matrix () binding changed this cycle. Yay!
Comment 4 Michael Catanzaro 2013-07-15 03:53:57 UTC 
Created attachment 249156 [details] [review]
2D: fix board numbering when Black is on bottom
Comment 5 Michael Catanzaro 2013-07-15 03:57:23 UTC 
This last patch should work with Vala 0.16-0.20 and is intended for the gnome-3-8 branch.

Still need to fix 3D view.
Comment 6 Michael Catanzaro 2013-07-20 02:24:05 UTC 
Created attachment 249671 [details] [review]
3D: fix board numbering when Black is on bottom
Comment 7 Michael Catanzaro 2013-07-20 02:33:07 UTC 
Thanks for reporting this bug!

Attachment 249154 [details] pushed as fb63931 - 2D: fix board numbering when Black is on bottom
Attachment 249155 [details] pushed as 2337f74 - Depend on unreleased Vala
Attachment 249671 [details] pushed as a5732fd - 3D: fix board numbering when Black is on bottom