After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703443 - dnd: Make the draggable much faster
dnd: Make the draggable much faster
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-07-02 06:09 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2013-07-03 00:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dnd: Make the draggable much faster (6.75 KB, patch)
2013-07-02 06:09 UTC, Jasper St. Pierre (not reading bugmail) 		reviewed Details | Review
dnd: Make the draggable much faster (6.59 KB, patch)
2013-07-02 18:17 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2013-07-02 06:09:04 UTC 
It turns out that picking a 3200x1200 scene on notebook chipsets
every time the mouse is moved isn't exactly the fastest thing. Defer
picking to an idle to ensure that it won't get in the way of keeping
up with mouse events.
Comment 1 Jasper St. Pierre (not reading bugmail) 2013-07-02 06:09:06 UTC 
Created attachment 248198 [details] [review]
dnd: Make the draggable much faster
Comment 2 drago01 2013-07-02 08:29:19 UTC 
Review of attachment 248198 [details] [review]:

Nice idea. The subject is kind of odd (I though you wanted to let it move faster or something). Maybe something like "dnd: Pick on idle" ?

Also probably worth doing something similar for XDND.

::: js/ui/dnd.js
@@ +363,3 @@
+        let target = this._dragActor.get_stage().get_actor_at_pos(Clutter.PickMode.ALL,
+                                                                  this._dragX, this._dragY);
+        // We call observers only once per motion with the innermost

This is no longer true then (no longer gets called once per motion event).
Comment 3 Jasper St. Pierre (not reading bugmail) 2013-07-02 18:17:10 UTC 
Created attachment 248252 [details] [review]
dnd: Make the draggable much faster

It turns out that picking a 3200x1200 scene on notebook chipsets
every time the mouse is moved isn't exactly the fastest thing. Defer
picking to an idle to ensure that it won't get in the way of keeping
up with mouse events.
Comment 4 drago01 2013-07-02 20:49:40 UTC 
Review of attachment 248252 [details] [review]:

OK.
Comment 5 Jasper St. Pierre (not reading bugmail) 2013-07-03 00:10:17 UTC 
Attachment 248252 [details] pushed as 317b9a9 - dnd: Make the draggable much faster