After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 703135 - AV1-MS:1-CD:1-7.1: DestroyObject of container fails
AV1-MS:1-CD:1-7.1: DestroyObject of container fails
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: MediaExport plugin
git master
Other Linux
: Normal normal
: ---
Assigned To: Jens Georg
rygel-maint
ivi
Depends on:
Blocks:
 
 
Reported: 2013-06-26 15:31 UTC by Jens Georg
Modified: 2013-08-06 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Delete container action (1.97 KB, patch)
2013-07-25 21:30 UTC, Parthiban Balasubramanian
needs-work Details | Review
server: Fix recursive removal of items (1.48 KB, patch)
2013-08-05 11:17 UTC, Jens Georg
committed Details | Review
media-export: Implement recursive container removal (2.64 KB, patch)
2013-08-05 11:18 UTC, Jens Georg
committed Details | Review
media-export: Emit containerUpdateID on playlist (1.21 KB, patch)
2013-08-05 11:44 UTC, Jens Georg
committed Details | Review

Description Jens Georg 2013-06-26 15:31:45 UTC
MediaExport does not allow this currently.
Comment 1 Parthiban Balasubramanian 2013-07-25 21:28:53 UTC
Same failure was seen with DLNA 7.3.122.8. I have attached the patch to fix the destroy container action.
Comment 2 Parthiban Balasubramanian 2013-07-25 21:30:29 UTC
Created attachment 250145 [details] [review]
Delete container action
Comment 3 Jens Georg 2013-07-30 08:23:40 UTC
Review of attachment 250145 [details] [review]:

On top of that, I'm wondering whether we really should allow to do this.

::: src/plugins/media-export/rygel-media-export-writable-db-container.vala
@@ +113,3 @@
+        var container = this.media_db.get_object (id);
+
+        yield this.remove_child_tracked (container);

This only removes the container from the database. On the next start-up, it will be re-added.
Comment 4 Jens Georg 2013-08-05 11:17:32 UTC
Created attachment 250846 [details] [review]
server: Fix recursive removal of items
Comment 5 Jens Georg 2013-08-05 11:18:02 UTC
Created attachment 250847 [details] [review]
media-export: Implement recursive container removal
Comment 6 Jens Georg 2013-08-05 11:35:49 UTC
With this, the test still fails if it happens to pick the Playlist folder.
Comment 7 Jens Georg 2013-08-05 11:44:12 UTC
Created attachment 250850 [details] [review]
media-export: Emit containerUpdateID on playlist
Comment 8 Parthiban Balasubramanian 2013-08-05 14:08:26 UTC
Patch looks good.
Comment 9 Jens Georg 2013-08-05 15:57:07 UTC
I'm thinking of limiting the actual removal to "guarded" objects, though; these are created remotely so only objects that were created remotely are allowed to be removed remotely (that's what we do in the tracker plug-in as well) with maybe an override switch.
Comment 10 Parthiban Balasubramanian 2013-08-05 16:00:48 UTC
I was considering that. But then I thought any unrestricted object(restricted flag not set) can be destroyed by destroyobject action. So do we really need to make it a guarded.?
Did I read the meaning of guarded correct.
Comment 11 Jens Georg 2013-08-06 13:17:55 UTC
Attachment 250846 [details] pushed as 331626c - server: Fix recursive removal of items
Attachment 250847 [details] pushed as 9398caa - media-export: Implement recursive container removal
Attachment 250850 [details] pushed as 43aea6c - media-export: Emit containerUpdateID on playlist