GNOME Bugzilla – Bug 703107
User list > login screen transition
Last modified: 2021-07-05 14:19:49 UTC
Right now we fade one out and then fade the other in. A better approach would be: * Fade out all elements except the user image and name * Move the user image and name into the position they will occupy in the login screen * Fade in the other login screen elements Related bugs: * Bug 703106 * Bug 702309 * Bug 685304
*** Bug 685304 has been marked as a duplicate of this bug. ***
Created attachment 257907 [details] [review] patch changes : js/ui/userWidget.js: Due to differences in layout between a user in login-screen and in authprompt, i introduce an abstract BaseUserWidget class and two derived classes : UserWidget ( which can act like the old one, for compatibility ) and LoginUserWidget ( which act like the old layout in loginDialog.js ) Both can also modify there sensibility with : at runtime with .setSensible(true|false) or at creation time with {sensible:true|false} ) Corresponding .css styles stay the same as before. js/gdm/loginDialog.js : Animation is changed, according to the new design and is not using Actor clone anymore : ( except the fadeout in gdm/utils.js) The item in the list is detached and replaced by an empty one, when we go back to the list, the item is re-attached at his old position. js/gdm/utils.js : minor change in fadeOutActor() to have a perfect animation.
Created attachment 257908 [details] video
Ooh, thanks for the patch slaf! This looks cool.
and please don't acn this patch, i must do a little correction : if (this._activatedItem.actor) must be if (this._activatedItem) to avoid a warning : this._activatedItem undefined
Created attachment 260279 [details] [review] 1/3 userWidget: Add a BaseUserWidget class and rebase UserWidget on it The purpose of this is to add more flexibility for futur changes in LoginDialog userWidget.
Created attachment 260280 [details] [review] 2/3 UserWidget: add a LoginUserWidget class Needed for futur changes in LoginDialog.js
Created attachment 260281 [details] [review] 3/3 loginDialog : new animation Using class LoginUserWidget to simplify code, we use the new animation of user at login.
On overwiew it works fine here at master with your patches. I try to do review on some of them.
Review of attachment 260279 [details] [review]: looks fine for the pourpose of future patches. Not sure if it alone has sense, since we are not using "sensitivity" yet.
Review of attachment 260280 [details] [review]: I would make a patch with this and the use of this before creating the animation, so we can have a logical step here with some clean-up (all the unneded code from loginDialog deleted) and not just a class added alone. That probably would help to review the next patch, which is the difficult an tricky one.
Review of attachment 260281 [details] [review]: In general the result looks fine. However, after trying to review it lot of times, I see a lot of tricky code like the deattaching and reataching actors, and giving them width and position -1 that I can guess there's some better manner to do it. Since I'm not that experienced, I would let the review of this patch (of an updated one with previous reviews)for a experienced developer. Thanks for your work and hope someone more experienced review this or updated patches =)
*** Bug 706631 has been marked as a duplicate of this bug. ***
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/ Thank you for your understanding and your help.