GNOME Bugzilla – Bug 703057
Inconsistent behavior selecting a picture for a wallpaper
Last modified: 2014-07-18 16:30:29 UTC
User can notice that system has 2 behaviors depending what wallpaper was set before. Having selected a wallpaper from "Wallpapers", adding an image as background will stretch it, having selected a color from "Colors" will make the picture tile. Steps : 1. Boot 2. Have a 1280 x 1024 image in Pictures folder (smaller than native resolution) 3. Go to settings - background 4. Press on background 5. From the "Wallpapers" tab, select a bluish one and apply 6. Press again on background, go to "Pictures" tab and add the pictures as a wallpaper 7. observe it's mode stretched 8. Press again on background, go to "Colors" tab and select a color and accept it as wallpaper 9. Press again on background and go to "Pictures" tab and add the pictures as a wallpaper 10. Observe now it's "tile" mode (pictures will repeat it self) Expected outcome User should be able to select how the image will display Actual outcome Image will display stretched / tile depending on what was before
Created attachment 248726 [details] [review] Proposed patch
Review of attachment 248726 [details] [review]: Works for me.
Review of attachment 248726 [details] [review]: Using the zoom placement means that it will look different from what it used to, selecting the same picture, and that it doesn't actually fix the root of the problem (which was that the placement wasn't overridden when selecting a background from the pictures source). ::: panels/background/bg-pictures-source.c @@ +294,3 @@ picture_opened_for_read, bg_source); g_object_unref (file); + Whitespace change here. ::: panels/background/cc-background-item.c @@ -418,3 @@ cc_background_item_get_placement (CcBackgroundItem *item) { - g_return_val_if_fail (CC_IS_BACKGROUND_ITEM (item), G_DESKTOP_BACKGROUND_STYLE_SCALED); I would have put those changes in a separate commit.
Created attachment 281069 [details] [review] background: Fix semi-random placement style when selecting "Picture" When selecting a background from the Pictures source, make sure that the placement is reset from whatever it was set to before, otherwise it will make use of the previous one, leading to tiled wallpapers if a colour was selected before, for example.
Attachment 281069 [details] pushed as c33e98d - background: Fix semi-random placement style when selecting "Picture"