After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702996 - Port to the new private macros and API
Port to the new private macros and API
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks: 702563
 
 
Reported: 2013-06-24 17:51 UTC by Emmanuele Bassi (:ebassi)
Modified: 2013-07-09 08:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bump GLib dependency to 2.37.3 (791 bytes, patch)
2013-06-24 19:42 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
gdk: Use new WITH_PRIVATE macros to define types (3.20 KB, patch)
2013-06-24 19:42 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
a11y: Use new macros for defining private data (31.73 KB, patch)
2013-06-24 19:42 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
gtk: Use new macros for defining private data (300.08 KB, patch)
2013-07-04 23:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
deprecated: Use the new macros for adding instance private data (14.43 KB, patch)
2013-07-04 23:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
gtk-demo: Use the new macros for adding instance private data (1.60 KB, patch)
2013-07-04 23:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
tests: Use the new macros for adding instance private data (2.09 KB, patch)
2013-07-04 23:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review
docs: Update the coding style (2.67 KB, patch)
2013-07-04 23:18 UTC, Emmanuele Bassi (:ebassi) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2013-06-24 17:51:23 UTC 
bump the dependency to GLib 2.37.3, then use G_DEFINE_WITH_PRIVATE, G_DEFINE_ABSTRACT_WITH_TYPE, and G_ADD_PRIVATE when defining types.
Comment 1 Emmanuele Bassi (:ebassi) 2013-06-24 19:42:25 UTC 
Created attachment 247677 [details] [review]
Bump GLib dependency to 2.37.3
Comment 2 Emmanuele Bassi (:ebassi) 2013-06-24 19:42:30 UTC 
Created attachment 247678 [details] [review]
gdk: Use new WITH_PRIVATE macros to define types

Drop the g_type_class_add_private() function, and use the macros
instead.
Comment 3 Emmanuele Bassi (:ebassi) 2013-06-24 19:42:36 UTC 
Created attachment 247679 [details] [review]
a11y: Use new macros for defining private data
Comment 4 Matthias Clasen 2013-06-29 04:01:51 UTC 
Review of attachment 247678 [details] [review]:

ok
Comment 5 Matthias Clasen 2013-06-29 04:02:05 UTC 
Review of attachment 247677 [details] [review]:

ok
Comment 6 Matthias Clasen 2013-06-29 04:02:49 UTC 
Review of attachment 247679 [details] [review]:

only spot-checked. looks ok
Comment 7 Emmanuele Bassi (:ebassi) 2013-07-04 23:18:21 UTC 
Created attachment 248421 [details] [review]
gtk: Use new macros for defining private data
Comment 8 Emmanuele Bassi (:ebassi) 2013-07-04 23:18:30 UTC 
Created attachment 248422 [details] [review]
deprecated: Use the new macros for adding instance private data
Comment 9 Emmanuele Bassi (:ebassi) 2013-07-04 23:18:39 UTC 
Created attachment 248423 [details] [review]
gtk-demo: Use the new macros for adding instance private data
Comment 10 Emmanuele Bassi (:ebassi) 2013-07-04 23:18:47 UTC 
Created attachment 248424 [details] [review]
tests: Use the new macros for adding instance private data
Comment 11 Emmanuele Bassi (:ebassi) 2013-07-04 23:18:55 UTC 
Created attachment 248425 [details] [review]
docs: Update the coding style

We should mention that newly written code should not have the private
data pointer in the instance structure, and that private data should be
added using the new GObject macros.
Comment 12 Emmanuele Bassi (:ebassi) 2013-07-05 01:22:48 UTC 
attachment 248421 [details] [review] is pretty big and boring. I tested with gtk-demo, but I guess we'll only find out if I forgot something once we get the buildbot to try and run the smoketest and the installed test suite.
Comment 13 Matthias Clasen 2013-07-09 03:41:46 UTC 
Yeah, lets get this in now so we can find possible issues
Comment 14 Emmanuele Bassi (:ebassi) 2013-07-09 08:44:20 UTC 
Attachment 247677 [details] pushed as e77733e - Bump GLib dependency to 2.37.3
Attachment 247679 [details] pushed as 365919d - a11y: Use new macros for defining private data
Attachment 248421 [details] pushed as 0899ef7 - gtk: Use new macros for defining private data
Attachment 248422 [details] pushed as 84186ef - deprecated: Use the new macros for adding instance private data
Attachment 248423 [details] pushed as 76df3ba - gtk-demo: Use the new macros for adding instance private data
Attachment 248424 [details] pushed as a71def8 - tests: Use the new macros for adding instance private data
Attachment 248425 [details] pushed as 19bc27c - docs: Update the coding style