After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702988 - gdkpixbufoverlay: crashes if any property changes during playback when location property is not set
gdkpixbufoverlay: crashes if any property changes during playback when locat...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.7
Other All
: Normal major
: 1.1.4
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-24 15:36 UTC by Kishore Arepalli
Modified: 2013-08-21 19:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix for crash and location controlling added (2.60 KB, patch)
2013-06-24 15:36 UTC, Kishore Arepalli 		committed Details | Review

Description Kishore Arepalli 2013-06-24 15:36:12 UTC 
Created attachment 247653 [details] [review]
Fix for crash and location controlling added

- Crash in gdkpixbufoverlay, if any property changes during playback when location property is not set.

- Change of location during PLAYING state is missing.
Comment 1 Sebastian Dröge (slomo) 2013-07-01 10:06:23 UTC 
Review of attachment 247653 [details] [review]:

::: ext/gdk_pixbuf/gstgdkpixbufoverlay.c
@@ +223,3 @@
       overlay->location = g_value_dup_string (value);
+      if (!gst_gdk_pixbuf_overlay_load_image (overlay, &err)) {
+        GST_ERROR_OBJECT (overlay, ("Could not load overlay image. %s",

This needs some locking, if we allow changing these things from properties you need to protect all accesses everywhere to it with a mutex.
Comment 2 Kishore Arepalli 2013-07-01 10:41:55 UTC 
(In reply to comment #1)
> Review of attachment 247653 [details] [review]:
> 
> ::: ext/gdk_pixbuf/gstgdkpixbufoverlay.c
> @@ +223,3 @@
>        overlay->location = g_value_dup_string (value);
> +      if (!gst_gdk_pixbuf_overlay_load_image (overlay, &err)) {
> +        GST_ERROR_OBJECT (overlay, ("Could not load overlay image. %s",
> 
> This needs some locking, if we allow changing these things from properties you
> need to protect all accesses everywhere to it with a mutex.

Complete set_property method is already locked.
Comment 3 Sebastian Dröge (slomo) 2013-08-21 19:42:19 UTC 
commit 1e917822a979d86f3f4cc26ce2000b0a93fe48df
Author: Kishore Arepalli <kishore.arepalli@gmail.com>
Date:   Mon Jun 24 17:29:37 2013 +0200

    gdkpixbufoverlay: crashes if any property changes during playback when location property is not set
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702988