GNOME Bugzilla – Bug 702825
Slider trough should have rounded ends
Last modified: 2013-06-25 13:51:39 UTC
Right now the ends of the trough are square. They should be rounded: https://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/volume.png I tried setting -slider-radius from the theme, but that didn't work. Is there a property for this? If there's not, can we have one please? :)
Created attachment 247482 [details] [review] slider: Extend the trough to the allocation extents This aligns the edge of the slider with the allocation of items under it, which is what we want to happen in the new aggregate menu.
Created attachment 247483 [details] [review] slider: Use clutter_cairo_set_source_color This cuts down on the denseness of the code.
Created attachment 247484 [details] [review] slider: Add rounded ends to sliders
Created attachment 247624 [details] screenshot Thanks for the patches Jasper. This looks good, but I would increase the radius - it should look like a half-circle (in the mockups the radius is 1.5). Maybe it would be good to have the radius in the theme?
Created attachment 247656 [details] [review] slider: Add rounded ends to sliders -- It is drawing a perfect circle. It's just that the stroke goes *outside* the bounds of the slider, so it gets cut off, making the shape not look like a circle. Here's one potential solution: add some padding to the slider so that we don't bump the stroke into the edge of the texture. Does this look better?
Review of attachment 247482 [details] [review]: LG.
Review of attachment 247483 [details] [review]: OK.
Review of attachment 247656 [details] [review]: Looks good, fine to push with design ack,
Attachment 247482 [details] pushed as a01469f - slider: Extend the trough to the allocation extents Attachment 247483 [details] pushed as 8d47afb - slider: Use clutter_cairo_set_source_color Let's push these two for now.
Created attachment 247717 [details] screenshot I'm running this with the latest patches, and it still doesn't look fully rounded.
Attachment 247656 [details] pushed as 109b29a - slider: Add rounded ends to sliders After IRC discussion, we discussed that, yes, it is rounded.
/me books an appointment at the optician