After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702782 - theme-node: fix support for box-shadow: none
theme-node: fix support for box-shadow: none
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-06-20 23:21 UTC by Cosimo Cecchi
Modified: 2013-06-25 17:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme-node: fix support for box-shadow: none (1.20 KB, patch)
2013-06-20 23:21 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2013-06-20 23:21:37 UTC 
When the theme wants to clear a box-shadow with a more specific selector that resets it to none, we currently ignore it.
See attached patch.
Comment 1 Cosimo Cecchi 2013-06-20 23:21:39 UTC 
Created attachment 247394 [details] [review]
theme-node: fix support for box-shadow: none

We currently don't parse "box-shadow: none", despite being valid CSS.
Fix it so that it uses the default shadow values.
Comment 2 drago01 2013-06-22 07:48:53 UTC 
Review of attachment 247394 [details] [review]:

OK, but remove the gvc hunk before pushing.
Comment 3 Cosimo Cecchi 2013-06-25 17:12:37 UTC 
Oops, indeed - I now pushed it without it.

Attachment 247394 [details] pushed as 0b219bf - theme-node: fix support for box-shadow: none