After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 702297 - opencv: build broken - c++ header indirectly included into c code (gstsegmentation.h contains a .hpp)
opencv: build broken - c++ header indirectly included into c code (gstsegment...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 1.1.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-14 22:15 UTC by Alban Browaeys
Modified: 2013-06-18 11:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
move c++ header include from c header to c++ implementation (1.35 KB, patch)
2013-06-14 22:15 UTC, Alban Browaeys 		committed Details | Review

Description Alban Browaeys 2013-06-14 22:15:35 UTC 
Created attachment 246861 [details] [review]
move c++ header include from c header to c++ implementation

ext/opencv/gstsegmentation.h include a c++ header (thus failure to build since gcc fails to find c++ list container) . since commit c313e1d3 .
moving #include <opencv2/video/background_segm.hpp> from the header to the implementation of gstsegmentation fixes the issue
    In file included from gstsegmentation.h:51:0,
                     from gstopencv.c:42:
    /usr/include/opencv2/video/background_segm.hpp:47:16: fatal error: list:
    No such file or directory
     #include <list>
                    ^
    compilation terminated.
Comment 1 Miguel Casas 2013-06-18 11:38:17 UTC 
LGTM, sorry I missed it.
Comment 2 Sebastian Dröge (slomo) 2013-06-18 11:46:19 UTC 
commit 90b51562ab7956c4fe7893ebb45f8cf44772901b
Author: Alban Browaeys <prahal@yahoo.com>
Date:   Sat Jun 15 00:12:18 2013 +0200

    opencv: fixes build by moving the c++ header to gstsegmentation.cpp
    
    Fixes:
    In file included from gstsegmentation.h:51:0,
                     from gstopencv.c:42:
    /usr/include/opencv2/video/background_segm.hpp:47:16: fatal error: list:
    No such file or directory
     #include <list>
                    ^
    compilation terminated.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702297
Comment 3 Tim-Philipp Müller 2013-06-18 11:49:48 UTC 
Also needed this here:


commit 67e71d7931b3573663ff31ae0e4ffff225f2b163
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Tue Jun 18 12:46:07 2013 +0100

    opencv: fix CFLAGS order and add plugins base libs includes to CXXFLAGS
    
    https://bugzilla.gnome.org/show_bug.cgi?id=702297