GNOME Bugzilla – Bug 702166
Language page and Input sources page "next" without complete
Last modified: 2018-09-21 16:10:27 UTC
Should we force the user to set a value for language and input source? Currently you can press next through this and you'll just end up with the OS defaults. If you don't select a language then you get a blank input sources selection screen which isn't great. We could have a default setup for these things, en_US for lang/input and read a /usr/share/gnome-initial-setup/defaults.conf which would allow oem/distro customisation of the defaults.
(In reply to comment #0) > We could have a default setup for these things, en_US for lang/input and read a > /usr/share/gnome-initial-setup/defaults.conf which would allow oem/distro > customisation of the defaults. That sounds good. If we go down that route, we should show the default language at the top of the list, with the check mark against it (this will mean that the next button will always be sensitive).
I don't think /usr/share/gnome-initial-setup/defaults.conf makes much sense for this, to be honest. It is just another place to store the same information, when we already have too many. I would prefer that we make it so that the OS default is selected if you don't make any changes and just hit next. And by 'selected', I mean properly selected, ie do whatever is necessary to a) make the region panel in the control center reflect this selection and b) pick the input sources defaults in the next page based on it.
(In reply to comment #2) ... > I would prefer that we make it so that the OS default is selected if you don't > make any changes and just hit next. And by 'selected', I mean properly > selected, ie do whatever is necessary to a) make the region panel in the > control center reflect this selection and b) pick the input sources defaults in > the next page based on it. Sounds good to me.
Created attachment 246910 [details] [review] language: Write out the settings when leaving the page Similarly to commit 7bfd8ff32418639e730cde0b4b2aca4da1b11885, if users just clicked next without explicitly clicking a language row they'd end up with an empty setting. -- This should be enough since we already have code to always have a selected row when starting up.
I don't understand this. I really want to prevent as much as possible from using the "Next Page" hook. As many things as possible should be in a stable state. I guess I don't understand why this happens. We select a row when we start up based on the system locale. Why can't the keyboard page pick up on this system locale?
Created attachment 246915 [details] [review] language: Make sure the initially selected language gets saved If users just clicked next without explicitly clicking a language row they'd end up with an empty setting. To prevent that we can write out the language selected by default on initialization. -- (In reply to comment #5) > I guess I don't understand why this happens. We select a row when we start up > based on the system locale. Why can't the keyboard page pick up on this system > locale? Sure we can do that. What's the reason to avoid the Next button?
Comment on attachment 246915 [details] [review] language: Make sure the initially selected language gets saved Ended up pushing this to the 3.8 branch to fix the non-new-user mode where we don't create a user account and the user never explicitly selected a language in the first page.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-initial-setup/issues/15.