GNOME Bugzilla – Bug 701957
Ignore Google documents without a thumbnail URI
Last modified: 2013-06-14 15:36:40 UTC
I've just upgraded to 3.8.3, and every document I try to open makes document crash. I've tried just before with 3.8.2, and it was working fine. LANG=C gnome-documents error: The metadata does not have a thumbnail property (gnome-documents:3147): GnomeDesktop-WARNING **: Unable to create loader for mime type application/msword: Unrecognized image file format (gnome-documents:3147): GnomeDesktop-WARNING **: Error creating thumbnail for file:///home/baptiste/Documents/CV%20&%20LM/bmillemathias_resume.doc: Unrecognized image file format (gnome-documents:3147): libgdata-WARNING **: Adding a kind category term, 'http://schemas.google.com/docs/2007#pdf', to an entry of kind 'http://schemas.google.com/docs/2007#document'. (gnome-documents:3147): libgdata-WARNING **: Adding a kind category term, 'http://schemas.google.com/docs/2007#spreadsheet', to an entry of kind 'http://schemas.google.com/docs/2007#document'. (gnome-documents:3147): libgdata-WARNING **: Adding a kind category term, 'http://schemas.google.com/docs/2007#pdf', to an entry of kind 'http://schemas.google.com/docs/2007#document'. (gnome-documents:3147): libgdata-WARNING **: Adding a kind category term, 'http://schemas.google.com/docs/2007#pdf', to an entry of kind 'http://schemas.google.com/docs/2007#document'. (gnome-documents:3147): libgdata-WARNING **: Adding a kind category term, 'http://schemas.google.com/docs/2007#pdf', to an entry of kind 'http://schemas.google.com/docs/2007#document'. (gnome-documents:3147): libsoup-CRITICAL **: soup_message_new: assertion `uri_string != NULL' failed ** libgdata:ERROR:gdata/services/documents/gdata-documents-service.c:307:append_query_headers: assertion failed: (message != NULL) Abandon
Might be related to [1] or [2]. Does it only happen with Google documents? Debarshi, can you look into this? [1] https://git.gnome.org/browse/gnome-documents/commit/?h=gnome-3-8&id=0a03910a9fb32e8c2999e27e0686557d8bd43d4e [2] https://git.gnome.org/browse/gnome-documents/commit/?h=gnome-3-8&id=128e8ba90167bcad3785bca78be0adeab132fea0
Both local and Google documents work fine for me. Would it be possible to have a backtrace? You can do so by attaching GDB to a running gnome-documents process and then triggering the crash.
Looking at the backtrace on this downstream bug https://bugzilla.redhat.com/show_bug.cgi?id=974063 I will lay the blame on the thumbnail downloading code. Investigating.
It will be helpful if someone can narrow it down to the particular file that is causing this. You can try putting something like the following in src/documents.js just before the GData.DownloadStream is created in the createThumbnail method of GoogleDocument: log(this.uri); log(this.name); Then delete everything inside ~/.cache/thumbnails/ and start gnome-documents from a terminal.
Created attachment 246815 [details] [review] documents: Ignore Google documents without a thumbnail URI Turns out that some Google documents might not have a server provided thumbnail URI. This is reflected in the documentation for gdata_documents_document_get_thumbnail_uri , which I should have read more closely. Many thanks to Jiri Eischmann (who filed the downstream report against Fedora) for letting me have the file that was causing this crash.
It might be nice to have a 3.8.3.1 with this fix.
Review of attachment 246815 [details] [review]: Looks good to me.
(In reply to comment #6) > It might be nice to have a 3.8.3.1 with this fix. Feel free to release; otherwise I'll probably get to it before Monday together with 3.9.3.
Comment on attachment 246815 [details] [review] documents: Ignore Google documents without a thumbnail URI Thanks for the review. I will release a 3.8.3.1 shortly.