GNOME Bugzilla – Bug 701903
If built with --enable-ubuntu-online-accounts, accounts dialog always opens the UOA one
Last modified: 2018-05-22 16:11:50 UTC
Ubuntu GNOME would like to ship GNOME with Empathy with GOA integration but without UOA integration (since it confuses users to have two places to enter account info and the dependency on libqtwebkit4 and other Qt libraries makes our ISO bigger than it needs to be). We are limited because as an official flavor we have to use the same empathy packaging as Ubuntu. Ubuntu's Empathy is built with GOA and with UOA. 1. Install Ubuntu's Empathy 2. Be sure to install the mcp-account-manager-goa plugin and not the mcp-account-manager-uoa plugin 3. Click the Accounts link in the Empathy app menu (there's a similar link to set up accounts in the empty contact list if you don't have any accounts configured yet). What happens Nothing (assuming you don't have gnome-control-center-signon installed and similar UOA bits) What should happen Instead of being a build-time check, Empathy should do a run-time check for the mcp-account-manager-uoa plugin. I have isolated this bug to https://git.gnome.org/browse/empathy/commit/?id=92ab370
Created attachment 249857 [details] [review] Check desktop session to determine which accounts panel to launch
Review of attachment 249857 [details] [review]: ::: src/empathy-accounts-dialog.c @@ +2707,1 @@ +#ifdef HAVE_GOA that code builds fine without GOA, I don't think you need that #ifdef @@ +2754,1 @@ launch_empathy_accounts (selected_account, if_needed, hidden); What if you have neither GOA nor UOA ? I think you should remove that #ifdef
Created attachment 253915 [details] [review] Check desktop session to determine which accounts panel to launch
Doesn't that mean that if one install gnome-shell on a 'pure' Ubuntu he won't be able to use UOA anymore?
Under unity it will launch the UOA panel, under any other session it will launch goa dialog.
Review of attachment 253915 [details] [review]: ::: src/empathy-accounts-dialog.c @@ +2723,3 @@ { #ifdef HAVE_UOA + if (!g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity")) { coding style nitpicking: we usually do "== 0" with g_strcmp0, and the { goes to next line.
Created attachment 266093 [details] [review] Check desktop session to determine which accounts panel to launch
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/701.