GNOME Bugzilla – Bug 701813
Reverse playback not working with videotestsrc
Last modified: 2013-10-08 19:47:35 UTC
Created attachment 246282 [details] Test file Hi, reverse playback is not working with videotestsrc : - Reproduced on 0.10 SDK and 1.0 HEAD - Working fine with audiotestsrc audiotestsrc and videotestsrc are both used for gap on Gstreamer Editing Services. So with this issue not reverse playback can be done on timeline with gaps. In attachement a simple program showing the issue on videotestsrc and showing that it is working fine on videotestsrc. For 1.0, you will have to change if (!gst_element_query_position (GST_ELEMENT (pipeline), &format, &position)) { to if (!gst_element_query_position (GST_ELEMENT (pipeline), format, &position)) {
Created attachment 246283 [details] [review] Add a testsuite to check videotestsrc in reverse playback
Created attachment 256673 [details] [review] videotestsrc: implement reverse playback Would you mind testing this in GES's scenarios?
(In reply to comment #2) > Created an attachment (id=256673) [details] [review] > videotestsrc: implement reverse playback > > Would you mind testing this in GES's scenarios? I've tried it with playback-test, but with no success: ./playback-test 1 "videotestsrc num-buffers=1000 ! xvimagesink"
Created attachment 256678 [details] [review] videotestsrc: implement reverse playback Updated patch, had forgotten to update the duration of the buffers
Created attachment 256679 [details] [review] videotestsrc: implement reverse playback Sorry, added too much to the last patch, try this one.
Comment on attachment 246283 [details] [review] Add a testsuite to check videotestsrc in reverse playback Maybe check timestamps, durations and position query too? Otherwise of course looks good
(In reply to comment #6) > (From update of attachment 246283 [details] [review]) > Maybe check timestamps, durations and position query too? Otherwise of course > looks good Looks rather small and safe, can we merge in 1.2 ?
commit 866f132821086359c699f0058b73b4e12e1dc2f6 Author: Thiago Santos <ts.santos@partner.samsung.com> Date: Tue Oct 8 00:08:34 2013 -0300 videotestsrc: implement reverse playback Decrement the n_frames counter when doing reverse playback to have timestamps and offsets reducing instead of increasing https://bugzilla.gnome.org/show_bug.cgi?id=701813
FYI I've created bug #709646 for the query duration enhancement when num-buffers is set.
Also pushed the tests. I think it makes sense to backport to 1.2. I can do it after dealing with #709646