After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701776 - world-3.10: Add the dLeyna servers as dependencies for GNOME Photos
world-3.10: Add the dLeyna servers as dependencies for GNOME Photos
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: module sets
unspecified
Other All
: Normal enhancement
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on: 701775
Blocks:
 
 
Reported: 2013-06-07 09:28 UTC by Emanuele Aina
Modified: 2013-06-20 13:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
world-3.10: Add the dLeyna servers as dependencies for GNOME Photos (1.95 KB, patch)
2013-06-07 09:28 UTC, Emanuele Aina
needs-work Details | Review
apps-3.10: Add the dLeyna servers as dependencies for GNOME Photos (1.90 KB, patch)
2013-06-10 09:08 UTC, Emanuele Aina
committed Details | Review

Description Emanuele Aina 2013-06-07 09:28:24 UTC
These are the rules used to simplify the development of bug #701775 (Send
pictures to remote DLNA renderers from GNOME Photos).

Even if there's no hard dependency from Photos on any component of the dLeyna
framework (every communication happens over DBus and we gracefully degrade if
we fail to activate the DBus service at startup) I've added one in the
moduleset to ensure that dleyna-renderer will be available when launching
gnome-photos.
Comment 1 Emanuele Aina 2013-06-07 09:28:27 UTC
Created attachment 246235 [details] [review]
world-3.10: Add the dLeyna servers as dependencies for GNOME Photos
Comment 2 Matthias Clasen 2013-06-08 01:19:33 UTC
I've just moved gnome-photos to gnome-apps-3.10
Comment 3 Matthias Clasen 2013-06-09 13:58:38 UTC
Review of attachment 246235 [details] [review]:

see previous comment
Comment 4 Emanuele Aina 2013-06-10 09:08:17 UTC
Created attachment 246388 [details] [review]
apps-3.10: Add the dLeyna servers as dependencies for GNOME Photos

Moved to apps-3.10 accordingly to gnome-photos.
Comment 5 Matthias Clasen 2013-06-11 12:55:24 UTC
Review of attachment 246388 [details] [review]:

Does gnome-photos' configure pick this dependency up automagically, or do you need to add --enable-dleyna or something like that ?
Anyway, looks ok to me
Comment 6 Emanuele Aina 2013-06-11 13:01:43 UTC
The patch for GNOME Photos only adds a runtime dependency: if Photos is unable to load the appropriate DBus interfaces it will just disable the feature.

Thanks for the review!
Comment 7 Craig Keogh 2013-06-20 12:34:12 UTC
Comment on attachment 246388 [details] [review]
apps-3.10: Add the dLeyna servers as dependencies for GNOME Photos

Thank you for patch and the review. Committed.
https://git.gnome.org/browse/jhbuild/commit/?id=f9f4f430054ab03003e17840edfed10ca61e7102
Comment 8 Emanuele Aina 2013-06-20 13:27:25 UTC
I wasn't expecting it to be committed before the GNOME Photos patches, but thanks! :D