After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701753 - Handle SPICE connection errors
Handle SPICE connection errors
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: 3.22
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-06-06 17:16 UTC by Christophe Fergeau
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle SPICE connection errors (1.50 KB, patch)
2013-06-06 17:16 UTC, Christophe Fergeau 		accepted-commit_now Details | Review
Handle SPICE connection errors (3.04 KB, patch)
2013-06-07 08:54 UTC, Christophe Fergeau 		committed Details | Review

Description Christophe Fergeau 2013-06-06 17:16:38 UTC 
When an error occurs during SPICE connection, a channel-event event
is emitted, and its type is SPICE_CHANNEL_ERROR_XXX. Boxes currently
catches some channel-event events, but does not do anything in case
of errors. When such an error occurs (for example because of a wrong
remote host certificate), Boxes UI is stuck on a centered half zoomed
screen, and does not do anything.
By emitting the disconnected() signal when such an error is caught, we
ensure we will go back to the collection view.
Comment 1 Christophe Fergeau 2013-06-06 17:16:40 UTC 
Created attachment 246175 [details] [review]
Handle SPICE connection errors
Comment 2 Zeeshan Ali 2013-06-06 18:51:15 UTC 
Review of attachment 246175 [details] [review]:

ACK, should we also display some message to user?
Comment 3 Christophe Fergeau 2013-06-07 08:47:55 UTC 
Review of attachment 246175 [details] [review]:

Yup, exactly my thoughts after sleeping on it, I'll submit a patch doing that.
Comment 4 Christophe Fergeau 2013-06-07 08:54:47 UTC 
Created attachment 246230 [details] [review]
Handle SPICE connection errors

When an error occurs during SPICE connection, a channel-event event
is emitted, and its type is SPICE_CHANNEL_ERROR_XXX. Boxes currently
catches some channel-event events, but does not do anything in case
of errors. When such an error occurs (for example because of a wrong
remote host certificate), Boxes UI is stuck on a centered half zoomed
screen, and does not do anything.
By emitting the disconnected() signal when such an error is caught, we
ensure we will go back to the collection view.
Comment 5 Christophe Fergeau 2013-06-07 15:41:25 UTC 
Attachment 246230 [details] pushed as d3ff984 - Handle SPICE connection errors
Comment 6 Christophe Fergeau 2013-06-07 15:42:17 UTC 
Bleh, forgot I had sent an unreviewed v2 before pushing, sorry about that. I'll revert if there are issues with it.
Comment 7 Zeeshan Ali 2013-06-07 19:12:09 UTC 
Review of attachment 246230 [details] [review]:

Looks good. No need to revert. :)