After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701714 - Don't send a SoupMessage if we only want the thumbnail path
Don't send a SoupMessage if we only want the thumbnail path
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: http backend
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks: 698315
 
 
Reported: 2013-06-06 12:03 UTC by Debarshi Ray
Modified: 2013-06-06 14:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
http: Don't send a SoupMessage if we only want the thumbnail path (980 bytes, patch)
2013-06-06 12:05 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2013-06-06 12:03:36 UTC 
The value of G_FILE_ATTRIBUTE_THUMBNAIL_PATH is calculated by g_vfs_backend_add_auto_info which does not involve the network. So, if the thumbnail path is all that has been asked for, there is no need to send a SoupMessage.

Not only is it a minor optimization, but it would also be nice to be able to read G_FILE_ATTRIBUTE_THUMBNAIL_PATH in the absence of a network. eg., in Documents and Photos we want to show the thumbnails of content on Google Documents, Flickr, etc.. and it would be nice to have the thumbnail path without a network because the thumbnail might already have been cached locally.
Comment 1 Debarshi Ray 2013-06-06 12:05:11 UTC 
Created attachment 246150 [details] [review]
http: Don't send a SoupMessage if we only want the thumbnail path
Comment 2 Ondrej Holy 2013-06-06 14:32:43 UTC 
Review of attachment 246150 [details] [review]:

It looks good.
Comment 3 Debarshi Ray 2013-06-06 14:54:02 UTC 
Thanks for the review. Pushed to both master and gnome-3-8.