After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701595 - Latest GIT version of v4l2src fails to compile on older kernels
Latest GIT version of v4l2src fails to compile on older kernels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.0.7
Other Linux
: Normal normal
: 1.1.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-06-04 14:11 UTC by Stirling Westrup
Modified: 2013-06-04 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (460 bytes, patch)
2013-06-04 14:56 UTC, Stirling Westrup 		committed Details | Review

Description Stirling Westrup 2013-06-04 14:11:56 UTC 
The v4l2src source code in git has started unconditionally using V4L2_CTRL_TYPE_BITMASK, a recently-introduced control type in the v4l2 kernel driver. As a result, the source fails to compile on versions of the kernel prior to that symbol's introduction.

As a result the element cannot be built on kernels as recent as 2.6.32.
Comment 1 Stirling Westrup 2013-06-04 14:56:53 UTC 
Created attachment 246011 [details] [review]
Proposed patch

Rather than just complaining, I took a look and the issue is trivial to solve. Here's a proposed patch (which I hope I did correctly. I don't often build patches).
Comment 2 Sebastian Dröge (slomo) 2013-06-04 15:04:46 UTC 
commit 86405d6ee775aa1982177a9f9f01802bc72d19bd
Author: Stirling Westrup <swestrup@gmail.com>
Date:   Tue Jun 4 17:04:11 2013 +0200

    v4l2: Fix compilation with older kernels
    
    https://bugzilla.gnome.org/show_bug.cgi?id=701595