After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701386 - dash: Minor cleanup
dash: Minor cleanup
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2013-05-31 19:01 UTC by Florian Müllner
Modified: 2013-05-31 22:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dash: Simplify some code (1.27 KB, patch)
2013-05-31 19:01 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2013-05-31 19:01:51 UTC 
The first hunk removes some code dupliction, the second one fixes a (harmless) warning when trying to remove a non-favorite app from favorites.
Comment 1 Florian Müllner 2013-05-31 19:01:55 UTC 
Created attachment 245773 [details] [review]
dash: Simplify some code
Comment 2 Jasper St. Pierre (not reading bugmail) 2013-05-31 19:13:09 UTC 
Review of attachment 245773 [details] [review]:

Doesn't this change behavior? The commit message should be expanded.
Comment 3 Florian Müllner 2013-05-31 19:15:05 UTC 
(In reply to comment #2)
> Doesn't this change behavior? The commit message should be expanded.

Only in the sense that there's one warning less on stderr ...
Comment 4 Jasper St. Pierre (not reading bugmail) 2013-05-31 19:18:17 UTC 
Review of attachment 245773 [details] [review]:

OK.
Comment 5 Florian Müllner 2013-05-31 22:36:00 UTC 
Attachment 245773 [details] pushed as bd6e0ce - dash: Simplify some code