After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701384 - rtsp-server needs to handle framed=true in addition to parsed=true
rtsp-server needs to handle framed=true in addition to parsed=true
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
git master
Other Mac OS
: Normal normal
: 1.2.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2013-05-31 18:41 UTC by Davide Bertola
Modified: 2014-02-25 22:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] [aacparse] add parsed=true in src caps (1002 bytes, application/octet-stream)
2013-05-31 18:41 UTC, Davide Bertola 		  Details
[PATCH] aacparse: add parsed=true in src caps (1.26 KB, patch)
2013-05-31 18:55 UTC, Davide Bertola 		rejected Details | Review

Description Davide Bertola 2013-05-31 18:41:32 UTC 
Created attachment 245766 [details]
[PATCH] [aacparse] add parsed=true in src caps

The aacparse plugin does not set parse=true in srcpad caps.

This results in problems using gst-rtsp-server.
gst-rtsp-media-factory-uri autoplugs demuxers, decoders and parsers until the stream is "parsed", and then it chooses the right rtp payloader. An AAC audio stream always gets decoded to raw PCM audio, and then payloaded as MP4A-LATM. This way it is not possible to create an rtp stream with AAC audio.

If the aacparse plugin sets "parsed=true" instead, it works as expected. See  patch.
Comment 1 Davide Bertola 2013-05-31 18:55:46 UTC 
Created attachment 245768 [details] [review]
[PATCH] aacparse: add parsed=true in src caps
Comment 2 Wim Taymans 2013-06-03 12:34:44 UTC 
It sounds more like rtsp-server should also look for the framed=true flag. We don't really have any good properties to marked the parsed state.
Comment 3 Tim-Philipp Müller 2013-08-22 17:47:33 UTC 
commit 3766914a184635896d05b2eda7d2addf86e86f1d
Author: Tim-Philipp Müller <tim@centricular.net>
Date:   Thu Aug 22 18:39:59 2013 +0100

    rtsp-media-factory-uri: check AAC properly for whether it's parsed or not
    
    For AAC we need to check for framed=true instead of parsed=true.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=701384