After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701332 - Patch for minor glitch in NSTextInput
Patch for minor glitch in NSTextInput
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Quartz
2.24.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-quartz maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2013-05-31 08:17 UTC by ek.kato
Modified: 2013-07-27 21:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to clear preedit correctly (1001 bytes, patch)
2013-05-31 08:17 UTC, ek.kato 		committed Details | Review

Description ek.kato 2013-05-31 08:17:14 UTC 
Created attachment 245705 [details] [review]
Patch to clear preedit correctly

In the patch of Bug #694273, I forgot to clear the preedit string when unmarkText() is called.  This patch fixes a problem for the following situateion.

Correct behavior:
  1. convert some Hiragana to Kanji, which has its length more than one Kanji character, with pressing space key
  2. press delete key
  3. it should delete only the last character and the former characters should be committed

Wrong behavior (without this patch):
  3' the former characters are committed, but the string is additionally still shown as if is is a preedit sting


Also I changed to use gchar instead of char appropriately in some places.  I think this patch should be applied to master and gtk-3-8 branch too.
Comment 1 John Ralls 2013-07-27 21:35:48 UTC 
Comment on attachment 245705 [details] [review]
Patch to clear preedit correctly

Committed to master, gtk-2-4, and gtk-3-8. Thanks.